Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Issue 10918262: views: Forward declare NativeWebKeyboardEvent instead of including its header file. (Closed)

Created:
8 years, 3 months ago by tfarina
Modified:
8 years, 3 months ago
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

views: Forward declare NativeWebKeyboardEvent instead of including its header file. BUG=125846 TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=157033

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M chrome/browser/ui/views/unhandled_keyboard_event_handler.h View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tfarina
TBRing...
8 years, 3 months ago (2012-09-16 01:38:35 UTC) #1
Ben Goodger (Google)
8 years, 3 months ago (2012-09-17 16:00:03 UTC) #2
lgtm


On Sat, Sep 15, 2012 at 6:38 PM, <tfarina@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Message:
> TBRing...
>
> Description:
> views: Forward declare NativeWebKeyboardEvent instead of including its
> header
> file.
>
> BUG=125846
> TBR=ben@chromium.org
>
>
> Please review this at
http://codereview.chromium.**org/10918262/<http://codereview.chromium.org/109...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   M chrome/browser/ui/views/**unhandled_keyboard_event_**handler.h
>
>
> Index: chrome/browser/ui/views/**unhandled_keyboard_event_**handler.h
> diff --git a/chrome/browser/ui/views/**unhandled_keyboard_event_**handler.h
> b/chrome/browser/ui/views/**unhandled_keyboard_event_**handler.h
> index 0930a64cece63e8b149741e575dfaf**7fbcfcca12..**
> 9e0b981f46a4549b5f1380abd9c774**cab2f912ab 100644
> --- a/chrome/browser/ui/views/**unhandled_keyboard_event_**handler.h
> +++ b/chrome/browser/ui/views/**unhandled_keyboard_event_**handler.h
> @@ -5,12 +5,15 @@
>  #ifndef CHROME_BROWSER_UI_VIEWS_**UNHANDLED_KEYBOARD_EVENT_**HANDLER_H_
>  #define CHROME_BROWSER_UI_VIEWS_**UNHANDLED_KEYBOARD_EVENT_**HANDLER_H_
>
> -#include "content/public/browser/**native_web_keyboard_event.h"
> -#include "ui/views/view.h"
> +#include "base/basictypes.h"
> +
> +namespace content {
> +struct NativeWebKeyboardEvent;
> +}
>
>  namespace views {
>  class FocusManager;
> -}  // namespace views
> +}
>
>  // This class handles unhandled keyboard messages coming back from the
> renderer
>  // process.
>
>
>

Powered by Google App Engine
This is Rietveld 408576698