Update language tests to new optional parameter syntax and semantics.

tests/language/argument_definition2_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
+// VMOptions=--reject_named_argument_as_positional

[ngeoffray, 2012/09/16 08:35:27]

This won't work for dart2js, could you change the test instead to avoid adding
this? Or change test.py to always pass that option from now on?

[regis, 2012/09/17 17:16:42]

I notice now that this particular test did not need this change, since it runs
fine under both the old and new semantics. However, there are other tests that I
fixed in this cl that only run under the new semantics.

Unfortunately, this is still too early to run all tests under the new semantics,
because of some issues in the corelib (e.g. Date constructor). So I cannot yet
pass that flag from test.py.

I suggest that we leave it as is until this becomes an issue for dart2js. At
that time, I suspect that the core lib will be updated so that all tests can be
run under the new semantics. We can then pass the flag in test.py and remove
these VMOptions directives in the tests.

Would that work for you?

Thanks!

[ngeoffray, 2012/09/21 07:12:32]

No problem, let's do that and hope we can remove this flag ASAP.

 
 test1(bool passed, [a = 42]) {
   if (passed) {
     Expect.equals(54, a);
     Expect.isTrue(?a);
   } else {
     Expect.equals(42, a);
     Expect.isFalse(?a);
   }
   Expect.isTrue(?passed);
@@ skipping 57 matching lines @@
   closure = things[inscrutable(1)];
   closure();
 
   closure = things[inscrutable(2)];
   closure(true, 54);
   closure(false);
 
   test4(true, 54);
   test4(false);
 }