The Windows portion of Native Messagaing

chrome/browser/extensions/api/messaging/message_service.cc

Index: chrome/browser/extensions/api/messaging/message_service.cc
diff --git a/chrome/browser/extensions/api/messaging/message_service.cc b/chrome/browser/extensions/api/messaging/message_service.cc
index 3a33d2a6a28a96f7cf8e10e0f3a4cfd1e69e826a..41e1f3e2caf91a958aa6f89d156317cf917f328f 100644
--- a/chrome/browser/extensions/api/messaging/message_service.cc
+++ b/chrome/browser/extensions/api/messaging/message_service.cc
@@ -216,7 +216,7 @@ void MessageService::OpenChannelToNativeApp(
       NativeMessageProcessHost::TYPE_CONNECT;
 
   content::BrowserThread::PostTask(
-      content::BrowserThread::FILE,
+      content::BrowserThread::IO,

[rvargas (doing something else), 2012/11/29 01:19:23]

Why the IO thread?

[eaugusti, 2012/12/07 02:21:08]

Because Windows' FILE thread has a MessageLoopForIO that has a type of TYPE_UI
(because of some restrictions with Windows notifications) and we need to do
async IO that requires a MessageLoopForIO with TYPE_IO. See
http://code.google.com/searchframe#OAMlx_jo-ck/src/content/browser/browser_ma...

On 2012/11/29 01:19:23, rvargas wrote:

       FROM_HERE,
       base::Bind(&NativeMessageProcessHost::Create,
                  base::WeakPtr<NativeMessageProcessHost::Client>(
@@ -242,6 +242,8 @@ void MessageService::FinalizeOpenChannelToNativeApp(
   // Abandon the channel
   if (!native_process.get()) {
     LOG(ERROR) << "Failed to create native process.";
+    channel->opener->DispatchOnDisconnect(
+        GET_OPPOSITE_PORT_ID(receiver_port_id), true);
     return;
   }
   channel->receiver.reset(new NativeMessagePort(native_process.release()));