Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 10918254: [Mac] Move the lists of XIB files into a gypi file. (Closed)

Created:
8 years, 3 months ago by Robert Sesek
Modified:
8 years, 3 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

[Mac] Move the lists of XIB files into a gypi file. This creates lists of XIB files that Chromium has. It also lays the groundwork for editing XIB files on Xcode 4.4 by creating a fake project for working in Xcode. BUG=149763 TEST=No changes in build output. TBR=mark@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=157199

Patch Set 1 #

Patch Set 2 : Syntax error #

Total comments: 8

Patch Set 3 : Comments #

Patch Set 4 : '' #

Total comments: 2

Patch Set 5 : Add a comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+349 lines, -96 lines) Patch
A build/mac/edit_xibs.sh View 1 2 1 chunk +17 lines, -0 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 1 chunk +5 lines, -45 lines 0 comments Download
M chrome/chrome_dll.gypi View 2 chunks +4 lines, -51 lines 0 comments Download
A chrome/chrome_nibs.gyp View 1 2 3 4 1 chunk +252 lines, -0 lines 0 comments Download
A chrome/chrome_nibs.gypi View 1 2 3 1 chunk +71 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Robert Sesek
I'll do the re-save in a later CL after I write some documentation.
8 years, 3 months ago (2012-09-14 22:47:19 UTC) #1
Mark Mentovai
https://codereview.chromium.org/10918254/diff/2002/build/mac/edit_xibs.sh File build/mac/edit_xibs.sh (right): https://codereview.chromium.org/10918254/diff/2002/build/mac/edit_xibs.sh#newcode13 build/mac/edit_xibs.sh:13: SRC=$(dirname $(dirname $(dirname "$0"))) This will suck if the ...
8 years, 3 months ago (2012-09-17 17:52:16 UTC) #2
Robert Sesek
https://codereview.chromium.org/10918254/diff/2002/build/mac/edit_xibs.sh File build/mac/edit_xibs.sh (right): https://codereview.chromium.org/10918254/diff/2002/build/mac/edit_xibs.sh#newcode13 build/mac/edit_xibs.sh:13: SRC=$(dirname $(dirname $(dirname "$0"))) On 2012/09/17 17:52:16, Mark Mentovai ...
8 years, 3 months ago (2012-09-17 18:01:48 UTC) #3
Mark Mentovai
https://codereview.chromium.org/10918254/diff/2005/chrome/chrome_nibs.gyp File chrome/chrome_nibs.gyp (right): https://codereview.chromium.org/10918254/diff/2005/chrome/chrome_nibs.gyp#newcode32 chrome/chrome_nibs.gyp:32: 'type': 'executable', This is the gassiest target. At least ...
8 years, 3 months ago (2012-09-17 18:23:37 UTC) #4
Robert Sesek
https://codereview.chromium.org/10918254/diff/2005/chrome/chrome_nibs.gyp File chrome/chrome_nibs.gyp (right): https://codereview.chromium.org/10918254/diff/2005/chrome/chrome_nibs.gyp#newcode32 chrome/chrome_nibs.gyp:32: 'type': 'executable', On 2012/09/17 18:23:37, Mark Mentovai wrote: > ...
8 years, 3 months ago (2012-09-17 18:28:09 UTC) #5
Mark Mentovai
LGTM
8 years, 3 months ago (2012-09-17 18:28:51 UTC) #6
Robert Sesek
https://codereview.chromium.org/10918254/diff/2002/chrome/chrome_nibs.gyp File chrome/chrome_nibs.gyp (right): https://codereview.chromium.org/10918254/diff/2002/chrome/chrome_nibs.gyp#newcode32 chrome/chrome_nibs.gyp:32: 'type': 'executable', On 2012/09/17 17:52:16, Mark Mentovai wrote: > ...
8 years, 3 months ago (2012-09-17 18:28:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/10918254/7010
8 years, 3 months ago (2012-09-17 18:29:05 UTC) #8
commit-bot: I haz the power
Presubmit check for 10918254-7010 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 3 months ago (2012-09-17 18:29:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/10918254/7010
8 years, 3 months ago (2012-09-17 18:30:35 UTC) #10
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
8 years, 3 months ago (2012-09-17 18:34:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/10918254/7010
8 years, 3 months ago (2012-09-17 20:29:17 UTC) #12
commit-bot: I haz the power
8 years, 3 months ago (2012-09-17 20:46:51 UTC) #13
Retried try job too often for step(s) compile

Powered by Google App Engine
This is Rietveld 408576698