Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issue 10918248: Added virtual destructor. (Closed)

Created:
8 years, 3 months ago by michaelbai
Modified:
8 years, 3 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Added virtual destructor. Also fix the clang compiling error. BUG=143931 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=156859

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M android_webview/android_webview.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M android_webview/browser/aw_http_auth_handler_base.h View 1 chunk +1 line, -0 lines 0 comments Download
A + android_webview/browser/aw_http_auth_handler_base.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M android_webview/browser/aw_login_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M android_webview/browser/aw_login_delegate.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M android_webview/native/aw_http_auth_handler.h View 1 chunk +1 line, -0 lines 0 comments Download
M android_webview/native/aw_http_auth_handler.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
michaelbai
8 years, 3 months ago (2012-09-14 18:02:29 UTC) #1
Ben Murdoch
lgtm thanks Michael!
8 years, 3 months ago (2012-09-14 18:07:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaelbai@chromium.org/10918248/1
8 years, 3 months ago (2012-09-14 18:12:25 UTC) #3
commit-bot: I haz the power
Presubmit check for 10918248-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 3 months ago (2012-09-14 18:12:31 UTC) #4
michaelbai
On 2012/09/14 18:12:31, I haz the power (commit-bot) wrote: > Presubmit check for 10918248-1 failed ...
8 years, 3 months ago (2012-09-14 18:14:48 UTC) #5
benm (inactive)
lgtm
8 years, 3 months ago (2012-09-14 18:16:16 UTC) #6
commit-bot: I haz the power
8 years, 3 months ago (2012-09-14 18:17:43 UTC) #7

Powered by Google App Engine
This is Rietveld 408576698