Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issue 1091823002: Allow NEON on iOS. (Closed)

Created:
5 years, 8 months ago by mtklein_C
Modified:
5 years, 4 months ago
Reviewers:
mtklein, caryclark
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Allow NEON on iOS. I have nanobench building and running (Color32_arm_neon) on my iPad. No public API changes. TBR=reed@google.com BUG=skia: Committed: https://skia.googlesource.com/skia/+/e5043b7ea5170a639367b67c986568907576be4b

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : todone #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M gyp/opts.gyp View 1 1 chunk +1 line, -3 lines 0 comments Download
M include/core/SkPreConfig.h View 1 2 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
mtklein
5 years, 8 months ago (2015-04-16 19:55:58 UTC) #2
caryclark
lgtm
5 years, 8 months ago (2015-04-16 19:58:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1091823002/40001
5 years, 8 months ago (2015-04-16 20:00:36 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Mac10.7-Clang-Arm7-Debug-iOS-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac10.7-Clang-Arm7-Debug-iOS-Trybot/builds/62)
5 years, 8 months ago (2015-04-16 20:07:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1091823002/40001
5 years, 8 months ago (2015-04-17 13:36:44 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/e5043b7ea5170a639367b67c986568907576be4b
5 years, 8 months ago (2015-04-17 13:36:56 UTC) #10
mtklein
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1094843005/ by mtklein@google.com. ...
5 years, 8 months ago (2015-04-17 21:02:07 UTC) #11
mtklein
5 years, 8 months ago (2015-04-20 13:06:00 UTC) #12
Message was sent while issue was closed.
On 2015/04/17 21:02:07, mtklein wrote:
> A revert of this CL (patchset #3 id:40001) has been created in
> https://codereview.chromium.org/1094843005/ by mailto:mtklein@google.com.
> 
> The reason for reverting is: need to coordinate this with chrome gyps/gn.

http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...

Powered by Google App Engine
This is Rietveld 408576698