Cross-platform plumbing for resize-to-client

remoting/host/desktop_resizer.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef REMOTING_HOST_DESKTOP_RESIZER_H_
+#define REMOTING_HOST_DESKTOP_RESIZER_H_
+
+#include <string>
+
+#include "remoting/host/host_status_observer.h"
+
+#include "base/memory/scoped_ptr.h"
+
+namespace remoting {
+
+class DesktopResizer {

[Wez, 2012/09/15 22:39:08]

Add a comment explaining how to use this interface/class.

[Jamie, 2012/09/19 22:35:07]

Done.

+ public:
+  virtual ~DesktopResizer();
+
+  static scoped_ptr<DesktopResizer> Create();
+
+  virtual SkISize GetSize() = 0;
+  virtual void SetSize(const SkISize& size) = 0;

[Wez, 2012/09/15 22:39:08]

As discussed, swap this for a GetSizes(preferred_size)/SetSize(size) API pair.

[Jamie, 2012/09/19 22:35:07]

Done.

+
+  class HostStatusObserver : public remoting::HostStatusObserver {

[Wez, 2012/09/15 22:39:08]

I think it would make sense to keep the cross-platform resizing logic (e.g.
searching for a suitable dimensions to resize to from those available) in this
and make it ResizingHostStatusObserver, and keep DesktopResizer as a pure
interface with just the basic platform query/resize code in it.

[Jamie, 2012/09/19 22:35:07]

Done.

+   public:
+    explicit HostStatusObserver(DesktopResizer* desktop_resizer);
+    virtual ~HostStatusObserver();
+
+    // HostStatusObserver interface
+    virtual void OnClientAuthenticated(const std::string& jid) OVERRIDE;
+    virtual void OnClientDisconnected(const std::string& jid) OVERRIDE;
+    virtual void OnClientDimensionsChanged(const SkISize& size) OVERRIDE;
+
+   private:
+    DesktopResizer* desktop_resizer_;
+    SkISize original_size_;
+  };
+};
+
+}  // namespace remoting
+
+#endif  // REMOTING_HOST_DESKTOP_RESIZER_H_