Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 10918215: Refresh Guest session UI (Closed)

Created:
8 years, 3 months ago by Dmitry Polukhin
Modified:
8 years, 3 months ago
Reviewers:
sadrul, sky
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, ben+watch_chromium.org, tfarina, arv (Not doing code reviews), oshima+watch_chromium.org, stevenjb+watch_chromium.org
Visibility:
Public.

Description

Refresh Guest session UI Removed guest icons and add guest label in tray BUG=145546 TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=156757

Patch Set 1 #

Patch Set 2 : nit #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -25 lines) Patch
M ash/ash_strings.grd View 5 chunks +7 lines, -4 lines 0 comments Download
M ash/system/user/tray_user.h View 2 chunks +2 lines, -0 lines 0 comments Download
M ash/system/user/tray_user.cc View 1 4 chunks +47 lines, -12 lines 2 comments Download
D chrome/app/theme/default_100_percent/guest_icon.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/theme_resources.grd View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/guest_session_tab.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/resources/shared/images/guest_icon_standalone.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view.cc View 1 chunk +1 line, -7 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Dmitry Polukhin
8 years, 3 months ago (2012-09-13 17:04:44 UTC) #1
sadrul
ash/system/user LGTM http://codereview.chromium.org/10918215/diff/1001/ash/system/user/tray_user.cc File ash/system/user/tray_user.cc (right): http://codereview.chromium.org/10918215/diff/1001/ash/system/user/tray_user.cc#newcode274 ash/system/user/tray_user.cc:274: : static_cast<views::View*>(label_); Do you need the cast ...
8 years, 3 months ago (2012-09-13 17:11:31 UTC) #2
Dmitry Polukhin
http://codereview.chromium.org/10918215/diff/1001/ash/system/user/tray_user.cc File ash/system/user/tray_user.cc (right): http://codereview.chromium.org/10918215/diff/1001/ash/system/user/tray_user.cc#newcode274 ash/system/user/tray_user.cc:274: : static_cast<views::View*>(label_); On 2012/09/13 17:11:32, sadrul wrote: > Do ...
8 years, 3 months ago (2012-09-13 17:24:16 UTC) #3
sky
LGTM
8 years, 3 months ago (2012-09-13 18:25:12 UTC) #4
commit-bot: I haz the power
8 years, 3 months ago (2012-09-13 18:30:17 UTC) #5

Powered by Google App Engine
This is Rietveld 408576698