Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: google_apis/google_apis.gyp

Issue 10918196: include.gypi variables to specify API keys or use internal header for keys. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « google_apis/google_api_keys.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: google_apis/google_apis.gyp
diff --git a/google_apis/google_apis.gyp b/google_apis/google_apis.gyp
index b0b81e49c655d5bd206e1011bba7f29a71111606..aa09f4a5f62c4c3e10b7097ab9290d4c2aa1a04d 100644
--- a/google_apis/google_apis.gyp
+++ b/google_apis/google_apis.gyp
@@ -18,6 +18,37 @@
'../crypto/crypto.gyp:crypto',
'../net/net.gyp:net',
],
+ 'conditions': [
+ ['google_api_key!=""', {
+ 'defines': ['GOOGLE_API_KEY="<(google_api_key)"'],
+ }],
+ # Once the default definitions for the various keys in
+ # google_apis/google_api_keys.cc are all made empty, the next
+ # two conditionals can set just GOOGLE_DEFAULT_CLIENT_ID/SECRET.
+ # Until then, we have different semantics on the gyp variables
+ # google_default_client_id/secret and setting the environment
+ # variables of the (upper-case) same name (the latter are used
+ # as the default for unset client IDs/secrets, whereas the
+ # former overrides all client IDs/secrets).
+ # TODO(joi): Fix the above semantic mismatch once possible.
+ ['google_default_client_id!=""', {
+ 'defines': [
+ 'GOOGLE_CLIENT_ID_MAIN="<(google_default_client_id)"',
+ 'GOOGLE_CLIENT_ID_CLOUD_PRINT="<(google_default_client_id)"',
+ 'GOOGLE_CLIENT_ID_REMOTING="<(google_default_client_id)"',
+ ]
+ }],
+ ['google_default_client_secret!=""', {
+ 'defines': [
+ 'GOOGLE_CLIENT_SECRET_MAIN="<(google_default_client_secret)"',
+ 'GOOGLE_CLIENT_SECRET_CLOUD_PRINT="<(google_default_client_secret)"',
+ 'GOOGLE_CLIENT_SECRET_REMOTING="<(google_default_client_secret)"',
+ ]
+ }],
+ ['use_official_google_api_keys==1', {
+ 'defines': ['USE_OFFICIAL_GOOGLE_API_KEYS=1'],
+ }],
+ ],
'sources': [
'gaia/gaia_auth_consumer.cc',
'gaia/gaia_auth_consumer.h',
« no previous file with comments | « google_apis/google_api_keys.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698