Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 10918196: include.gypi variables to specify API keys or use internal header for keys. (Closed)

Created:
8 years, 3 months ago by Jói
Modified:
8 years, 3 months ago
Reviewers:
MAD
CC:
chromium-reviews
Visibility:
Public.

Description

include.gypi variables to specify API keys or use internal header for keys. BUG=145584 Committed as r156538

Patch Set 1 #

Patch Set 2 : Win fix #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -9 lines) Patch
M build/common.gypi View 1 2 1 chunk +18 lines, -0 lines 0 comments Download
M google_apis/google_api_keys.cc View 1 2 1 chunk +13 lines, -9 lines 0 comments Download
M google_apis/google_apis.gyp View 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Jói
8 years, 3 months ago (2012-09-12 15:45:50 UTC) #1
Jói
nsylvain -> mad for review MAD, could you review this? I want to get it ...
8 years, 3 months ago (2012-09-12 19:47:28 UTC) #2
MAD
lgtm
8 years, 3 months ago (2012-09-12 20:04:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/10918196/1
8 years, 3 months ago (2012-09-12 20:08:26 UTC) #4
commit-bot: I haz the power
Try job failure for 10918196-1 (retry) on win_rel for step "compile" (clobber build). It's a ...
8 years, 3 months ago (2012-09-12 20:36:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/10918196/7004
8 years, 3 months ago (2012-09-12 21:30:46 UTC) #6
commit-bot: I haz the power
Try job failure for 10918196-7004 (retry) on linux_chromeos for step "content_unittests". It's a second try, ...
8 years, 3 months ago (2012-09-12 22:44:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/10918196/9002
8 years, 3 months ago (2012-09-13 11:02:09 UTC) #8
commit-bot: I haz the power
8 years, 3 months ago (2012-09-13 12:14:50 UTC) #9
Retried try job too often for step(s) sync_integration_tests,
chrome_frame_unittests, safe_browsing_tests, mini_installer_test, ui_tests,
remoting_unittests, installer_util_unittests, gfx_unittests,
chrome_frame_net_tests, nacl_integration

Powered by Google App Engine
This is Rietveld 408576698