Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3441)

Unified Diff: chrome/browser/favicon/favicon_handler.cc

Issue 10918065: Introduce structures to reduce the number of arguments in the FaviconService methods. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: use copies rather than refs + fix nits. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/favicon/favicon_handler.cc
diff --git a/chrome/browser/favicon/favicon_handler.cc b/chrome/browser/favicon/favicon_handler.cc
index 6152d642145e580a1fc9333da8959a2586493e0c..0da0dea860666cbf49352d249b8898a543d5dd35 100644
--- a/chrome/browser/favicon/favicon_handler.cc
+++ b/chrome/browser/favicon/favicon_handler.cc
@@ -384,8 +384,10 @@ void FaviconHandler::GetFavicon(
history::IconType icon_type,
CancelableRequestConsumerBase* consumer,
const FaviconService::FaviconResultsCallback& callback) {
- GetFaviconService()->GetFavicon(icon_url, icon_type, preferred_icon_size(),
- ui::GetSupportedScaleFactors(), consumer, callback);
+ GetFaviconService()->GetFavicon(
+ FaviconService::FaviconParams(icon_url, icon_type,
+ preferred_icon_size(), consumer),
+ ui::GetSupportedScaleFactors(), callback);
}
void FaviconHandler::GetFaviconForURL(
@@ -393,9 +395,10 @@ void FaviconHandler::GetFaviconForURL(
int icon_types,
CancelableRequestConsumerBase* consumer,
const FaviconService::FaviconResultsCallback& callback) {
- GetFaviconService()->GetFaviconForURL(profile_, page_url, icon_types,
- preferred_icon_size(), ui::GetSupportedScaleFactors(), consumer,
- callback);
+ GetFaviconService()->GetFaviconForURL(
+ FaviconService::FaviconForURLParams(profile_, page_url, icon_types,
+ preferred_icon_size(), consumer),
+ ui::GetSupportedScaleFactors(), callback);
}
void FaviconHandler::SetHistoryFavicon(

Powered by Google App Engine
This is Rietveld 408576698