Introduce structures to reduce the number of arguments in the FaviconService methods.

chrome/browser/favicon/favicon_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/favicon/favicon_service.h"
 
 #include "chrome/browser/favicon/select_favicon_frames.h"
 #include "chrome/browser/history/history.h"
 #include "chrome/browser/history/history_backend.h"
 #include "chrome/browser/history/history_service_factory.h"
 #include "chrome/browser/ui/webui/chrome_web_ui_controller_factory.h"
 #include "chrome/common/url_constants.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 #include "ui/gfx/codec/png_codec.h"
 #include "ui/gfx/image/image_skia.h"
 
 FaviconService::FaviconService(HistoryService* history_service)
     : history_service_(history_service) {
 }
 
 FaviconService::Handle FaviconService::GetFaviconImage(
-    const GURL& icon_url,
-    history::IconType icon_type,
-    int desired_size_in_dip,
-    CancelableRequestConsumerBase* consumer,
+    const FaviconParams& params,
     const FaviconImageCallback& callback) {
   GetFaviconRequest* request = new GetFaviconRequest(base::Bind(
       &FaviconService::GetFaviconImageCallback,
       base::Unretained(this),
-      desired_size_in_dip,
+      params.desired_size_in_dip,
       callback));
-  AddRequest(request, consumer);
+  AddRequest(request, params.consumer);
   // TODO(pkotwicz): Pass in desired size and scale factors.
   if (history_service_)
-    history_service_->GetFavicon(request, icon_url, icon_type);
+    history_service_->GetFavicon(request, params.icon_url, params.icon_type);
   else
     ForwardEmptyResultAsync(request);
   return request->handle();
 }
 
 FaviconService::Handle FaviconService::GetRawFavicon(
-    const GURL& icon_url,
-    history::IconType icon_type,
-    int desired_size_in_dip,
+    const FaviconParams& params,
     ui::ScaleFactor desired_scale_factor,
-    CancelableRequestConsumerBase* consumer,
     const FaviconRawCallback& callback) {
   GetFaviconRequest* request = new GetFaviconRequest(base::Bind(
       &FaviconService::GetRawFaviconCallback,
       base::Unretained(this),
-      desired_size_in_dip,
+      params.desired_size_in_dip,
       desired_scale_factor,
       callback));
-  AddRequest(request, consumer);
+  AddRequest(request, params.consumer);
   // TODO(pkotwicz): Pass in desired size and scale factor.
   if (history_service_)
-    history_service_->GetFavicon(request, icon_url, icon_type);
+    history_service_->GetFavicon(request, params.icon_url, params.icon_type);
   else
     ForwardEmptyResultAsync(request);
   return request->handle();
 }
 
 FaviconService::Handle FaviconService::GetFavicon(
-    const GURL& icon_url,
-    history::IconType icon_type,
-    int desired_size_in_dip,
+    const FaviconParams& params,
     const std::vector<ui::ScaleFactor>& desired_scale_factors,
-    CancelableRequestConsumerBase* consumer,
     const FaviconResultsCallback& callback) {
   GetFaviconRequest* request = new GetFaviconRequest(callback);
-  AddRequest(request, consumer);
+  AddRequest(request, params.consumer);
   if (history_service_)
-    history_service_->GetFavicon(request, icon_url, icon_type);
+    history_service_->GetFavicon(request, params.icon_url, params.icon_type);
   else
     ForwardEmptyResultAsync(request);
   return request->handle();
 }
 
 FaviconService::Handle FaviconService::UpdateFaviconMappingAndFetch(
     const GURL& page_url,
     const GURL& icon_url,
     history::IconType icon_type,
     CancelableRequestConsumerBase* consumer,
     const FaviconResultsCallback& callback) {
   GetFaviconRequest* request = new GetFaviconRequest(callback);
   AddRequest(request, consumer);
   if (history_service_)
     history_service_->UpdateFaviconMappingAndFetch(request, page_url,
                                                    icon_url, icon_type);
   else
     ForwardEmptyResultAsync(request);
   return request->handle();
 }
 
 FaviconService::Handle FaviconService::GetFaviconImageForURL(
-    Profile* profile,
-    const GURL& page_url,
-    int icon_types,
-    int desired_size_in_dip,
-    CancelableRequestConsumerBase* consumer,
+    const FaviconForURLParams& params,
     const FaviconImageCallback& callback) {
   GetFaviconRequest* request = new GetFaviconRequest(base::Bind(
       &FaviconService::GetFaviconImageCallback,
       base::Unretained(this),
-      desired_size_in_dip,
+      params.desired_size_in_dip,
       callback));
 
   std::vector<ui::ScaleFactor> desired_scale_factors =
       ui::GetSupportedScaleFactors();
-  return GetFaviconForURLImpl(profile, page_url, icon_types,
-      desired_size_in_dip, desired_scale_factors, consumer, request);
+  return GetFaviconForURLImpl(params, desired_scale_factors, request);
 }
 
 FaviconService::Handle FaviconService::GetRawFaviconForURL(
-    Profile* profile,
-    const GURL& page_url,
-    int icon_types,
-    int desired_size_in_dip,
+    const FaviconForURLParams& params,
     ui::ScaleFactor desired_scale_factor,
-    CancelableRequestConsumerBase* consumer,
     const FaviconRawCallback& callback) {
   GetFaviconRequest* request = new GetFaviconRequest(base::Bind(
       &FaviconService::GetRawFaviconCallback,
       base::Unretained(this),
-      desired_size_in_dip,
+      params.desired_size_in_dip,
       desired_scale_factor,
       callback));
 
   std::vector<ui::ScaleFactor> desired_scale_factors;
   desired_scale_factors.push_back(desired_scale_factor);
-  return GetFaviconForURLImpl(profile, page_url, icon_types,
-      desired_size_in_dip, desired_scale_factors, consumer, request);
+  return GetFaviconForURLImpl(params, desired_scale_factors, request);
 }
 
 FaviconService::Handle FaviconService::GetFaviconForURL(
-    Profile* profile,
-    const GURL& page_url,
-    int icon_types,
-    int desired_size_in_dip,
+    const FaviconForURLParams& params,
     const std::vector<ui::ScaleFactor>& desired_scale_factors,
-    CancelableRequestConsumerBase* consumer,
     const FaviconResultsCallback& callback) {
   GetFaviconRequest* request = new GetFaviconRequest(callback);
-  return GetFaviconForURLImpl(profile, page_url, icon_types,
-      desired_size_in_dip, desired_scale_factors, consumer, request);
+  return GetFaviconForURLImpl(params, desired_scale_factors, request);
 }
 
 FaviconService::Handle FaviconService::GetRawFaviconForID(
     history::FaviconID favicon_id,
     int desired_size_in_dip,
     ui::ScaleFactor desired_scale_factor,
     CancelableRequestConsumerBase* consumer,
     const FaviconRawCallback& callback) {
   GetFaviconRequest* request = new GetFaviconRequest(base::Bind(
       &FaviconService::GetRawFaviconCallback,
@@ skipping 36 matching lines @@
                                 const std::vector<unsigned char>& image_data,
                                 history::IconType icon_type) {
   if (history_service_)
     history_service_->SetFavicon(page_url, icon_url, image_data, icon_type);
 }
 
 FaviconService::~FaviconService() {
 }
 
 FaviconService::Handle FaviconService::GetFaviconForURLImpl(
-    Profile* profile,
-    const GURL& page_url,
-    int icon_types,
-    int desired_size_in_dip,
+    const FaviconForURLParams& params,
     const std::vector<ui::ScaleFactor>& desired_scale_factors,
-    CancelableRequestConsumerBase* consumer,
     GetFaviconRequest* request) {
-  AddRequest(request, consumer);
+  AddRequest(request, params.consumer);
   FaviconService::Handle handle = request->handle();
-  if (page_url.SchemeIs(chrome::kChromeUIScheme) ||
-      page_url.SchemeIs(chrome::kExtensionScheme)) {
+  if (params.page_url.SchemeIs(chrome::kChromeUIScheme) ||
+      params.page_url.SchemeIs(chrome::kExtensionScheme)) {
     // TODO(pkotwicz): Pass in desired size and desired scale factors.
     ChromeWebUIControllerFactory::GetInstance()->GetFaviconForURL(
-        profile, request, page_url);
+        params.profile, request, params.page_url);
   } else {
     // TODO(pkotwicz): Pass in desired size and desired scale factors.
     if (history_service_)

[awong, 2012/09/05 17:52:44]

nit: use braces for the if/else since one of the bodies spans multiple lines.

[Leandro Graciá Gil, 2012/09/05 18:28:37]

Done.

-      history_service_->GetFaviconForURL(request, page_url, icon_types);
+      history_service_->GetFaviconForURL(request,
+                                         params.page_url,
+                                         params.icon_types);
     else
       ForwardEmptyResultAsync(request);
   }
   return handle;
 }
 
 void FaviconService::GetFaviconImageCallback(
     int desired_size_in_dip,
     FaviconImageCallback callback,
     Handle handle,
@@ skipping 73 matching lines @@
   bitmap_result.bitmap_data = base::RefCountedBytes::TakeVector(
       &resized_bitmap_data);
   callback.Run(handle, bitmap_result);
 }
 
 void FaviconService::ForwardEmptyResultAsync(GetFaviconRequest* request) {
   request->ForwardResultAsync(request->handle(),
                               std::vector<history::FaviconBitmapResult>(),
                               history::IconURLSizesMap());
 }