Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Side by Side Diff: chrome/browser/ui/intents/web_intent_picker_controller.cc

Issue 10918065: Introduce structures to reduce the number of arguments in the FaviconService methods. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove the auxiliary structure for non-URL cases. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/intents/web_intent_picker_controller.h" 5 #include "chrome/browser/ui/intents/web_intent_picker_controller.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/bind_helpers.h" 10 #include "base/bind_helpers.h"
(...skipping 484 matching lines...) Expand 10 before | Expand all | Expand 10 after
495 const webkit_glue::WebIntentServiceData& service) { 495 const webkit_glue::WebIntentServiceData& service) {
496 FaviconService* favicon_service = GetFaviconService(tab_contents_); 496 FaviconService* favicon_service = GetFaviconService(tab_contents_);
497 497
498 picker_model_->AddInstalledService( 498 picker_model_->AddInstalledService(
499 service.title, 499 service.title,
500 service.service_url, 500 service.service_url,
501 service.disposition); 501 service.disposition);
502 502
503 pending_async_count_++; 503 pending_async_count_++;
504 FaviconService::Handle handle = favicon_service->GetFaviconImageForURL( 504 FaviconService::Handle handle = favicon_service->GetFaviconImageForURL(
505 tab_contents_->profile(), 505 FaviconService::FaviconForURLParams(
506 service.service_url, 506 tab_contents_->profile(),
507 history::FAVICON, 507 service.service_url,
508 gfx::kFaviconSize, 508 history::FAVICON,
509 &favicon_consumer_, 509 gfx::kFaviconSize,
510 &favicon_consumer_),
510 base::Bind( 511 base::Bind(
511 &WebIntentPickerController::OnFaviconDataAvailable, 512 &WebIntentPickerController::OnFaviconDataAvailable,
512 weak_ptr_factory_.GetWeakPtr())); 513 weak_ptr_factory_.GetWeakPtr()));
513 favicon_consumer_.SetClientData( 514 favicon_consumer_.SetClientData(
514 favicon_service, handle, picker_model_->GetInstalledServiceCount() - 1); 515 favicon_service, handle, picker_model_->GetInstalledServiceCount() - 1);
515 } 516 }
516 517
517 void WebIntentPickerController::OnWebIntentServicesAvailable( 518 void WebIntentPickerController::OnWebIntentServicesAvailable(
518 const std::vector<webkit_glue::WebIntentServiceData>& services) { 519 const std::vector<webkit_glue::WebIntentServiceData>& services) {
519 for (size_t i = 0; i < services.size(); ++i) 520 for (size_t i = 0; i < services.size(); ++i)
(...skipping 413 matching lines...) Expand 10 before | Expand all | Expand 10 after
933 UTF16ToUTF8(picker_model_->action()))); 934 UTF16ToUTF8(picker_model_->action())));
934 web_intents::RecordPickerShow(uma_bucket_); 935 web_intents::RecordPickerShow(uma_bucket_);
935 picker_shown_ = true; 936 picker_shown_ = true;
936 } 937 }
937 938
938 void WebIntentPickerController::ClosePicker() { 939 void WebIntentPickerController::ClosePicker() {
939 SetDialogState(kPickerHidden); 940 SetDialogState(kPickerHidden);
940 if (picker_) 941 if (picker_)
941 picker_->Close(); 942 picker_->Close();
942 } 943 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698