Issue 10918042: Use MakeWeak() to clean up function pointers in NativeHandler.

Issue 10918042: Use MakeWeak() to clean up function pointers in NativeHandler. (Closed)

Created:
8 years, 3 months ago by koz (OOO until 15th September)

Modified:
7 years, 11 months ago

Reviewers:
not at google - send to devlin

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Use MakeWeak() to clean up function pointers in NativeHandler. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176155

Patch Set 3 : respond to comments #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -10 lines)			Patch
M	chrome/renderer/extensions/module_system.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/extensions/native_handler.h	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	chrome/renderer/extensions/native_handler.cc	View	1 2	1 chunk	+16 lines, -6 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

koz (OOO until 15th September)

I found this change to remove an old TODO lying around.

8 years, 3 months ago (2012-09-03 00:55:53 UTC) #1

not at google - send to devlin

lgtm, sorry for forgetting to review this. https://codereview.chromium.org/10918042/diff/3001/chrome/renderer/extensions/native_handler.cc File chrome/renderer/extensions/native_handler.cc (right): https://codereview.chromium.org/10918042/diff/3001/chrome/renderer/extensions/native_handler.cc#newcode44 chrome/renderer/extensions/native_handler.cc:44: v8::HandleScope handle_scope; ...

7 years, 11 months ago (2013-01-07 19:43:43 UTC) #3

koz (OOO until 15th September)

Cheers! https://codereview.chromium.org/10918042/diff/3001/chrome/renderer/extensions/native_handler.cc File chrome/renderer/extensions/native_handler.cc (right): https://codereview.chromium.org/10918042/diff/3001/chrome/renderer/extensions/native_handler.cc#newcode44 chrome/renderer/extensions/native_handler.cc:44: v8::HandleScope handle_scope; On 2013/01/07 19:43:43, kalman wrote: > ...

7 years, 11 months ago (2013-01-07 22:55:28 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/koz@chromium.org/10918042/10001

7 years, 11 months ago (2013-01-07 22:58:04 UTC) #5

commit-bot: I haz the power

Retried try job too often on win_aura for step(s) content_browsertests

7 years, 11 months ago (2013-01-08 01:17:01 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/koz@chromium.org/10918042/10001

7 years, 11 months ago (2013-01-08 02:02:49 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/koz@chromium.org/10918042/10001

7 years, 11 months ago (2013-01-10 19:25:14 UTC) #8

Message was sent while issue was closed.

Change committed as 176155

Expand Messages | Collapse Messages