Apply automatic range checks to content enum types across IPC.

Apply automatic range checks to content enum types across IPC.

This is part of a long-running background task to remove the remaining
uses of the unchecked IPC_ENUM_TRAITS() macro.

BUG=246708
Committed: https://crrev.com/f4d6d9002afa1563ca3f9a8a981edfbd2ab9da6a
Cr-Commit-Position: refs/heads/master@{#325867}

[payal.pandey, 2015-04-16 13:46:15]

payal.pandey@samsung.com changed reviewers:
+ nasko@chromium.org, vitalybuka@chromium.org

[payal.pandey, 2015-04-16 13:46:55]

Please have a look and review the changes

[nasko, 2015-04-16 16:50:08]

Just one fix needed and it will be good to go.

https://codereview.chromium.org/1091773002/diff/1/content/common/view_messages.h
File content/common/view_messages.h (right):

https://codereview.chromium.org/1091773002/diff/1/content/common/view_message...
content/common/view_messages.h:89:
IPC_ENUM_TRAITS_MAX_VALUE(WindowContainerType, WINDOW_CONTAINER_TYPE_MAX_VALUE)
WINDOW_CONTAINER_TYPE_MAX_VALUE is one more than the last valid value.

[Vitaly Buka (NO REVIEWS), 2015-04-16 19:13:44]

I don't own these components

[Vitaly Buka (NO REVIEWS), 2015-04-16 19:13:56]

vitalybuka@chromium.org changed reviewers:
- vitalybuka@chromium.org

[payal.pandey, 2015-04-17 05:20:02]

Incorporated the review comments..
Please have a look..

[nasko, 2015-04-17 15:33:29]

LGTM

[payal.pandey, 2015-04-17 15:47:23]

On 2015/04/17 15:33:29, nasko wrote:
> LGTM

Thanks for lgtm :)

[payal.pandey, 2015-04-17 15:47:42]

The CQ bit was checked by payal.pandey@samsung.com

[payal.pandey, 2015-04-17 15:48:21]

The CQ bit was unchecked by payal.pandey@samsung.com

[commit-bot: I haz the power, 2015-04-17 15:48:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1091773002/20001

[payal.pandey, 2015-04-17 17:13:25]

The CQ bit was checked by payal.pandey@samsung.com

[commit-bot: I haz the power, 2015-04-17 17:14:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1091773002/20001

[commit-bot: I haz the power, 2015-04-17 17:25:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-17 17:25:51]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[payal.pandey, 2015-04-20 05:49:49]

The CQ bit was checked by payal.pandey@samsung.com

[payal.pandey, 2015-04-20 05:56:42]

payal.pandey@samsung.com changed reviewers:
+ derat@chromium.org

[payal.pandey, 2015-04-20 05:57:46]

Please review for font_render_params.h

[commit-bot: I haz the power, 2015-04-20 08:01:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1091773002/20001

[commit-bot: I haz the power, 2015-04-20 08:27:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-20 08:27:45]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Daniel Erat, 2015-04-20 13:04:09]

the specifics of this change are unclear to me from reading the bug and also
issue 176110. i saw an earlier change that used _LAST instead of _MAX -- what's
the reason for the difference?

if you get someone with knowledge of the larger change to lgtm this, adding
either _LAST or _MAX seems fine to me. i don't think i'm in the OWNERS file for
this, though.

[payal.pandey, 2015-04-20 17:05:31]

The CQ bit was checked by payal.pandey@samsung.com

[commit-bot: I haz the power, 2015-04-20 17:06:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1091773002/20001

[commit-bot: I haz the power, 2015-04-20 17:10:26]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-04-20 17:11:15]

Patchset 2 (id:??) landed as
https://crrev.com/f4d6d9002afa1563ca3f9a8a981edfbd2ab9da6a
Cr-Commit-Position: refs/heads/master@{#325867}

[nasko, 2015-04-20 20:43:15]

On 2015/04/20 17:11:15, I haz the power (commit-bot) wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/f4d6d9002afa1563ca3f9a8a981edfbd2ab9da6a
> Cr-Commit-Position: refs/heads/master@{#325867}

derat@ - It isn't a consistent usage and you have a good point that we should
try to enforce more consistency. I'm an IPC reviewer and I'm ok with the change,
so I've LGTMd it.

payal.pandey - Daniel didn't explicitly say "LGTM", even though it was in his
post. Your submission of this patch to the CQ wasn't following proper process.
Since it is mostly mechanical change, I'm going to leave it in. In the future,
please follow the process or such commits will be reverted.

[payal.pandey, 2015-04-21 05:32:29]

On 2015/04/20 20:43:15, nasko (very slow until 04-27) wrote:
> On 2015/04/20 17:11:15, I haz the power (commit-bot) wrote:
> > Patchset 2 (id:??) landed as
> > https://crrev.com/f4d6d9002afa1563ca3f9a8a981edfbd2ab9da6a
> > Cr-Commit-Position: refs/heads/master@{#325867}
> 
> derat@ - It isn't a consistent usage and you have a good point that we should
> try to enforce more consistency. I'm an IPC reviewer and I'm ok with the
change,
> so I've LGTMd it.
> 
> payal.pandey - Daniel didn't explicitly say "LGTM", even though it was in his
> post. Your submission of this patch to the CQ wasn't following proper process.
> Since it is mostly mechanical change, I'm going to leave it in. In the future,
> please follow the process or such commits will be reverted.

Sorry for some misinterpretation, by mistakenly checked for the committing this
CL.
Otherwise I would have follow the process.

Thanks for accepting this CL.