Fix up views web intents location bar decoration.

chrome/browser/ui/views/location_bar/location_bar_decoration_view.h

Index: chrome/browser/ui/views/location_bar/location_bar_decoration_view.h
diff --git a/chrome/browser/ui/views/location_bar/location_bar_decoration_view.h b/chrome/browser/ui/views/location_bar/location_bar_decoration_view.h
index 9445fb6f824f73174ee7084b623693d0a0769dc6..77ef4944fc147e3eefb747fb9bc719868c481393 100644
--- a/chrome/browser/ui/views/location_bar/location_bar_decoration_view.h
+++ b/chrome/browser/ui/views/location_bar/location_bar_decoration_view.h
@@ -12,6 +12,7 @@
 #include "chrome/common/content_settings_types.h"
 #include "ui/base/animation/animation_delegate.h"
 #include "ui/base/events/event.h"
+#include "ui/gfx/font.h"
 #include "ui/views/controls/image_view.h"
 #include "ui/views/painter.h"
 
@@ -60,6 +61,9 @@ class LocationBarDecorationView : public views::ImageView,
   // TouchableLocationBarView.
   virtual int GetBuiltInHorizontalPadding() const OVERRIDE;
 
+  // Set the font to be used for drawing the label.
+  void SetFont(const gfx::Font& font);

[Peter Kasting, 2012/09/15 00:23:46]

Nit: Name set_font() and inline

[Greg Billock, 2012/09/15 04:58:20]

You sure? This SetFont signature is used all over the place in this directory
and elsewhere.

On 2012/09/15 00:23:46, Peter Kasting wrote:

[Peter Kasting, 2012/09/17 20:04:27]

If the function is non-virtual and a cheap member accessor, it should be inlined
and named accordingly.

In a lot of cases we have SetFont() functions that violate one of these two
conditions (either they're virtual, or they change the font and then do other
stuff like call some "needs layout" function or something).  In a few cases, we
may simply have things named wrong because originally views violated the Chrome
style guide in a bunch of ways we've been slowly fixing over the years.

This applies to SetFontColor() too.

[Greg Billock, 2012/09/17 21:23:18]

OK, cool. I'll rename it.

On 2012/09/17 20:04:27, Peter Kasting wrote:

+
  protected:
   // Invoked when the user clicks on the control.
   virtual void OnClick(LocationBarView* parent) = 0;
@@ -90,6 +94,7 @@ class LocationBarDecorationView : public views::ImageView,
 
   scoped_ptr<ui::SlideAnimation> slide_animator_;
   string16 animated_text_;
+  gfx::Font font_;
   bool pause_animation_;
   double pause_animation_state_;
   int text_size_;