linux_aura: Make X11 selection buffers work on text in both direction.

content/browser/renderer_host/render_widget_host_view_aura.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_widget_host_view_aura.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/debug/trace_event.h"
@@ skipping 19 matching lines @@
 #include "ui/aura/client/aura_constants.h"
 #include "ui/aura/client/cursor_client.h"
 #include "ui/aura/client/screen_position_client.h"
 #include "ui/aura/client/stacking_client.h"
 #include "ui/aura/client/tooltip_client.h"
 #include "ui/aura/client/window_types.h"
 #include "ui/aura/env.h"
 #include "ui/aura/root_window.h"
 #include "ui/aura/window.h"
 #include "ui/aura/window_observer.h"
+#include "ui/base/clipboard/scoped_clipboard_writer.h"
 #include "ui/base/events/event.h"
 #include "ui/base/gestures/gesture_recognizer.h"
 #include "ui/base/hit_test.h"
 #include "ui/base/ime/input_method.h"
 #include "ui/base/ui_base_types.h"
 #include "ui/compositor/compositor.h"
 #include "ui/compositor/layer.h"
 #include "ui/gfx/canvas.h"
 #include "ui/gfx/display.h"
 #include "ui/gfx/screen.h"
@@ skipping 468 matching lines @@
   delete window_;
 }
 
 void RenderWidgetHostViewAura::SetTooltipText(const string16& tooltip_text) {
   tooltip_ = tooltip_text;
   aura::RootWindow* root_window = window_->GetRootWindow();
   if (aura::client::GetTooltipClient(root_window))
     aura::client::GetTooltipClient(root_window)->UpdateTooltip(window_);
 }
 
+void RenderWidgetHostViewAura::SelectionChanged(const string16& text,
+                                                size_t offset,
+                                                const ui::Range& range) {
+  RenderWidgetHostViewBase::SelectionChanged(text, offset, range);
+
+#if defined(USE_X11) && !defined(OS_CHROMEOS)
+  if (text.empty() || range.is_empty())
+    return;
+  size_t pos = range.GetMin() - offset;

[Daniel Erat, 2012/09/14 18:33:15]

is there any danger of negative overflow here?

[Elliot Glaysher, 2012/09/14 20:16:16]

I believe so. This check was added by penghuang@ in the gtk version, so I assume
this is IME fiddliness.

[Daniel Erat, 2012/09/14 20:38:17]

sorry -- i meant, should there also be:

  if (offset > range.GetMin()) {
    NOTREACHED() << "Offset " << offset << " makes range starting at "
                 << range.GetMin() << " precede beginning of text";
    return;
  }

?  pos will be huge in this case, which means we should hit the next
NOTREACHED(), so maybe it's not a big deal.

+  size_t n = range.length();

[Daniel Erat, 2012/09/14 18:33:15]

nit: you'll end up with the same number of lines but more-readable-code, IMHO,
if you remove this and just do:

  DCHECK(pos + range.length() <= text.length())
      << "The text cannot fully cover the range";

+
+  DCHECK(pos + n <= text.length()) << "The text can not fully cover range.";
+  if (pos >= text.length()) {
+    NOTREACHED() << "The text can not cover range.";
+    return;
+  }
+
+  // Set the BUFFER_SELECTION to the ui::Clipboard.
+  ui::ScopedClipboardWriter clipboard_writer(
+      ui::Clipboard::GetForCurrentThread(),
+      ui::Clipboard::BUFFER_SELECTION);
+  clipboard_writer.WriteText(text);
+#endif  // defined(USE_X11) && !defined(OS_CHROMEOS)
+}
+
 void RenderWidgetHostViewAura::SelectionBoundsChanged(
     const gfx::Rect& start_rect,
     WebKit::WebTextDirection start_direction,
     const gfx::Rect& end_rect,
     WebKit::WebTextDirection end_direction) {
   if (selection_start_rect_ == start_rect && selection_end_rect_ == end_rect)
     return;
 
   selection_start_rect_ = start_rect;
   selection_end_rect_ = end_rect;
@@ skipping 1218 matching lines @@
     RenderWidgetHost* widget) {
   return new RenderWidgetHostViewAura(widget);
 }
 
 // static
 void RenderWidgetHostViewPort::GetDefaultScreenInfo(WebScreenInfo* results) {
   GetScreenInfoForWindow(results, NULL);
 }
 
 }  // namespace content