Issue 10917160: Add some logging to debug PPAPI permissions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10917160: Add some logging to debug PPAPI permissions. (Closed)

Created:
8 years, 3 months ago by brettw

Modified:
8 years, 3 months ago

Reviewers:
nfullagar, nfullagar1

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add some logging to debug PPAPI permissions. Somehow these aren't getting set properly for the bundled Flash case. The code path we take to get them is pretty long, so this patch adds some temporary logging to try to see wher they're lost. BUG=147507 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=157040

Patch Set 1 #

Patch Set 2 : #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -3 lines)			Patch
M	chrome/browser/component_updater/pepper_flash_component_installer.cc	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	content/browser/renderer_host/pepper/browser_ppapi_host_impl.cc	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download
M	content/common/pepper_plugin_registry.cc	View		4 chunks	+15 lines, -0 lines	0 comments	Download
M	content/renderer/pepper/content_renderer_pepper_host_factory.cc	View		1 chunk	+6 lines, -3 lines	0 comments	Download
M	ppapi/shared_impl/ppapi_permissions.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...

8 years, 3 months ago (2012-09-11 00:23:29 UTC) #3

commit-bot: I haz the power

8 years, 3 months ago (2012-09-15 05:35:33 UTC) #5

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

Expand Messages | Collapse Messages