Add preliminary iOS support to more content/ gypi files

content/content_common.gypi

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'dependencies': [
     '../base/base.gyp:base',
     '../build/temp_gyp/googleurl.gyp:googleurl',
-    '../gpu/gpu.gyp:gles2_implementation',
-    '../gpu/gpu.gyp:gpu_ipc',
-    '../ipc/ipc.gyp:ipc',
     '../media/media.gyp:media',
-    '../media/media.gyp:shared_memory_support',
     '../net/net.gyp:net',
-    '../ppapi/ppapi_internal.gyp:ppapi_shared',
     '../skia/skia.gyp:skia',
     '../third_party/icu/icu.gyp:icuuc',
-    '../third_party/npapi/npapi.gyp:npapi',
-    '<(webkit_src_dir)/Source/WebKit/chromium/WebKit.gyp:webkit',
-    '../ui/gl/gl.gyp:gl',
     '../ui/ui.gyp:ui',
-    '../webkit/support/webkit_support.gyp:appcache',
-    '../webkit/support/webkit_support.gyp:blob',
-    '../webkit/support/webkit_support.gyp:database',
-    '../webkit/support/webkit_support.gyp:fileapi',
-    '../webkit/support/webkit_support.gyp:webkit_base',
   ],
   'include_dirs': [
     '..',
   ],
   'export_dependent_settings': [
     '../base/base.gyp:base',
   ],
   'sources': [
     'public/common/bindings_policy.h',
     'public/common/child_process_host.h',
@@ skipping 340 matching lines @@
     'public/common/common_param_traits.h',
     'public/common/common_param_traits_macros.h',
     'public/common/content_client.cc',
     'public/common/content_client.h',
     'public/common/window_container_type.cc',
     'public/common/window_container_type.h',
     'public/common/webkit_param_traits.cc',
     'public/common/webkit_param_traits.h',
   ],
   'conditions': [
+    ['OS!="ios"', {
+      'dependencies': [
+        '../gpu/gpu.gyp:gles2_implementation',
+        '../gpu/gpu.gyp:gpu_ipc',
+        '../ipc/ipc.gyp:ipc',
+        '../media/media.gyp:shared_memory_support',
+        '../ppapi/ppapi_internal.gyp:ppapi_shared',
+        '../third_party/npapi/npapi.gyp:npapi',
+        '<(webkit_src_dir)/Source/WebKit/chromium/WebKit.gyp:webkit',
+        '../ui/gl/gl.gyp:gl',
+        '../webkit/support/webkit_support.gyp:appcache',
+        '../webkit/support/webkit_support.gyp:blob',
+        '../webkit/support/webkit_support.gyp:database',
+        '../webkit/support/webkit_support.gyp:fileapi',
+        '../webkit/support/webkit_support.gyp:webkit_base',
+      ],
+    }],
     ['OS!="win"', {
       'sources!': [
         'common/sandbox_policy.cc',
         'common/sandbox_policy.h',
       ],
     }],
     ['OS=="android"',{
       'link_settings': {
         'libraries': [
           '-landroid',  # ANativeWindow
@@ skipping 120 matching lines @@
         ],
         'action': [
           'python',
         '../build/extract_from_cab.py',
         '..\\third_party\\directxsdk\\files\\Redist\\<(input)',
         '<(output)',
         '<(PRODUCT_DIR)',
         ],
       },
      ]
-    }]
+    }],
+    ['OS=="ios"', {

[jam, 2012/09/07 16:25:52]

move this to 374 and combine

[stuartmorgan, 2012/09/07 17:03:41]

FWIW, I separated them on purpose. Almost everywhere Android did the
combination, it made things harder to find, and in several cases I had to break
things apart. I like making the "dependencies that everyone that iOS" uses as
prominent as possible in the file, so they are easy to find, and the unusual iOS
stuff at the end of the target, since it's least relevant to most people in the
file.

I can recombine them if you feel strongly it's better that way, but I definitely
find this more readable.

[jam, 2012/09/10 05:46:07]

+mmentovai: do we have a convention for this sort of thing? if not, what do you
prefer?

[Mark Mentovai, 2012/09/10 12:54:41]

John Abd-El-Malek wrote:
Combine ’em. No sense in duplicating the same condition. This file already mixes
dependencies with other properties.

+      'sources/': [
+        # iOS only needs a small portion of content; exclude all the
+        # implementation, and re-include what is used.
+        ['exclude', '\\.(cc|mm)$'],
+        ['include', '_ios\\.(cc|mm)$'],
+        ['include', '^public/common/content_constants\\.cc$'],
+        ['include', '^public/common/content_switches\\.cc$'],
+        ['include', '^public/common/frame_navigate_params\\.cc$'],
+        ['include', '^public/common/page_transition_types\\.cc$'],
+        ['include', '^public/common/speech_recognition_result\\.cc$'],
+        ['include', '^public/common/url_constants\\.cc$'],
+        ['include', '^common/content_paths\\.cc$'],
+        ['include', '^common/net/url_fetcher\\.cc$'],
+        ['include', '^common/net/url_request_user_data\\.cc$'],
+        ['include', '^common/savable_url_schemes\\.cc$'],
+        ['include', '^common/url_schemes\\.cc$'],
+      ],
+    }],
   ],
 }