Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: chrome/browser/ui/browser_commands.cc

Issue 1091703002: Eliminate faux-RTTI code from BrowserView. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert to patch set 2 Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/browser_commands.h ('k') | chrome/browser/ui/browser_window.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser_commands.cc
diff --git a/chrome/browser/ui/browser_commands.cc b/chrome/browser/ui/browser_commands.cc
index cd20a116d77a4ad4440a3f735d628dd98c0ef451..90e6be26a667bd490229e8390daea3476e443267 100644
--- a/chrome/browser/ui/browser_commands.cc
+++ b/chrome/browser/ui/browser_commands.cc
@@ -918,19 +918,14 @@ bool CanEmailPageLocation(const Browser* browser) {
browser->tab_strip_model()->GetActiveWebContents()->GetURL().is_valid();
}
-void Cut(Browser* browser) {
- content::RecordAction(UserMetricsAction("Cut"));
- browser->window()->Cut();
-}
-
-void Copy(Browser* browser) {
- content::RecordAction(UserMetricsAction("Copy"));
- browser->window()->Copy();
-}
-
-void Paste(Browser* browser) {
- content::RecordAction(UserMetricsAction("Paste"));
- browser->window()->Paste();
+void CutCopyPaste(Browser* browser, int command_id) {
+ if (command_id == IDC_CUT)
+ content::RecordAction(UserMetricsAction("Cut"));
+ else if (command_id == IDC_COPY)
+ content::RecordAction(UserMetricsAction("Copy"));
+ else
+ content::RecordAction(UserMetricsAction("Paste"));
+ browser->window()->CutCopyPaste(command_id);
}
void Find(Browser* browser) {
« no previous file with comments | « chrome/browser/ui/browser_commands.h ('k') | chrome/browser/ui/browser_window.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698