Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: chrome/browser/ui/views/frame/browser_view.h

Issue 1091703002: Eliminate faux-RTTI code from BrowserView. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert to patch set 2 Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_VIEW_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_VIEW_H_
6 #define CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_VIEW_H_ 6 #define CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_VIEW_H_
7 7
8 #include <map> 8 #include <map>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 326 matching lines...) Expand 10 before | Expand all | Expand 10 after
337 void UserChangedTheme() override; 337 void UserChangedTheme() override;
338 void ShowWebsiteSettings(Profile* profile, 338 void ShowWebsiteSettings(Profile* profile,
339 content::WebContents* web_contents, 339 content::WebContents* web_contents,
340 const GURL& url, 340 const GURL& url,
341 const content::SSLStatus& ssl) override; 341 const content::SSLStatus& ssl) override;
342 void ShowAppMenu() override; 342 void ShowAppMenu() override;
343 bool PreHandleKeyboardEvent(const content::NativeWebKeyboardEvent& event, 343 bool PreHandleKeyboardEvent(const content::NativeWebKeyboardEvent& event,
344 bool* is_keyboard_shortcut) override; 344 bool* is_keyboard_shortcut) override;
345 void HandleKeyboardEvent( 345 void HandleKeyboardEvent(
346 const content::NativeWebKeyboardEvent& event) override; 346 const content::NativeWebKeyboardEvent& event) override;
347 void Cut() override; 347 void CutCopyPaste(int command_id) override;
348 void Copy() override;
349 void Paste() override;
350 WindowOpenDisposition GetDispositionForPopupBounds( 348 WindowOpenDisposition GetDispositionForPopupBounds(
351 const gfx::Rect& bounds) override; 349 const gfx::Rect& bounds) override;
352 FindBar* CreateFindBar() override; 350 FindBar* CreateFindBar() override;
353 web_modal::WebContentsModalDialogHost* GetWebContentsModalDialogHost() 351 web_modal::WebContentsModalDialogHost* GetWebContentsModalDialogHost()
354 override; 352 override;
355 void ShowAvatarBubbleFromAvatarButton( 353 void ShowAvatarBubbleFromAvatarButton(
356 AvatarBubbleMode mode, 354 AvatarBubbleMode mode,
357 const signin::ManageAccountsParams& manage_accounts_params) override; 355 const signin::ManageAccountsParams& manage_accounts_params) override;
358 int GetRenderViewHeightInsetWithDetachedBookmarkBar() override; 356 int GetRenderViewHeightInsetWithDetachedBookmarkBar() override;
359 void ExecuteExtensionCommand(const extensions::Extension* extension, 357 void ExecuteExtensionCommand(const extensions::Extension* extension,
(...skipping 185 matching lines...) Expand 10 before | Expand all | Expand 10 after
545 543
546 // Initialize the hung plugin detector. 544 // Initialize the hung plugin detector.
547 void InitHangMonitor(); 545 void InitHangMonitor();
548 546
549 // Possibly records a user metrics action corresponding to the passed-in 547 // Possibly records a user metrics action corresponding to the passed-in
550 // accelerator. Only implemented for Chrome OS, where we're interested in 548 // accelerator. Only implemented for Chrome OS, where we're interested in
551 // learning about how frequently the top-row keys are used. 549 // learning about how frequently the top-row keys are used.
552 void UpdateAcceleratorMetrics(const ui::Accelerator& accelerator, 550 void UpdateAcceleratorMetrics(const ui::Accelerator& accelerator,
553 int command_id); 551 int command_id);
554 552
555 // Calls |method| which is either WebContents::Cut, ::Copy, or ::Paste,
556 // first trying the content WebContents, then the devtools WebContents, and
557 // lastly the Views::Textfield if one is focused.
558 void DoCutCopyPaste(void (content::WebContents::*method)(),
559 int command_id);
560
561 // Calls |method| which is either WebContents::Cut, ::Copy, or ::Paste on 553 // Calls |method| which is either WebContents::Cut, ::Copy, or ::Paste on
562 // the given WebContents, returning true if it consumed the event. 554 // the given WebContents, returning true if it consumed the event.
563 bool DoCutCopyPasteForWebContents( 555 bool DoCutCopyPasteForWebContents(
564 content::WebContents* contents, 556 content::WebContents* contents,
565 void (content::WebContents::*method)()); 557 void (content::WebContents::*method)());
566 558
567 // Shows the next app-modal dialog box, if there is one to be shown, or moves 559 // Shows the next app-modal dialog box, if there is one to be shown, or moves
568 // an existing showing one to the front. 560 // an existing showing one to the front.
569 void ActivateAppModalDialog() const; 561 void ActivateAppModalDialog() const;
570 562
(...skipping 136 matching lines...) Expand 10 before | Expand all | Expand 10 after
707 scoped_ptr<ImmersiveModeController> immersive_mode_controller_; 699 scoped_ptr<ImmersiveModeController> immersive_mode_controller_;
708 700
709 scoped_ptr<WebContentsCloseHandler> web_contents_close_handler_; 701 scoped_ptr<WebContentsCloseHandler> web_contents_close_handler_;
710 702
711 mutable base::WeakPtrFactory<BrowserView> activate_modal_dialog_factory_; 703 mutable base::WeakPtrFactory<BrowserView> activate_modal_dialog_factory_;
712 704
713 DISALLOW_COPY_AND_ASSIGN(BrowserView); 705 DISALLOW_COPY_AND_ASSIGN(BrowserView);
714 }; 706 };
715 707
716 #endif // CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_VIEW_H_ 708 #endif // CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_VIEW_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_cocoa.mm ('k') | chrome/browser/ui/views/frame/browser_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698