Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Side by Side Diff: chrome/browser/ui/cocoa/browser_window_cocoa.h

Issue 1091703002: Eliminate faux-RTTI code from BrowserView. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert to patch set 2 Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/browser_window.h ('k') | chrome/browser/ui/cocoa/browser_window_cocoa.mm » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_COCOA_BROWSER_WINDOW_COCOA_H_ 5 #ifndef CHROME_BROWSER_UI_COCOA_BROWSER_WINDOW_COCOA_H_
6 #define CHROME_BROWSER_UI_COCOA_BROWSER_WINDOW_COCOA_H_ 6 #define CHROME_BROWSER_UI_COCOA_BROWSER_WINDOW_COCOA_H_
7 7
8 #include "base/mac/scoped_nsobject.h" 8 #include "base/mac/scoped_nsobject.h"
9 #include "base/memory/weak_ptr.h" 9 #include "base/memory/weak_ptr.h"
10 #include "chrome/browser/extensions/extension_keybinding_registry.h" 10 #include "chrome/browser/extensions/extension_keybinding_registry.h"
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
137 void UserChangedTheme() override; 137 void UserChangedTheme() override;
138 void ShowWebsiteSettings(Profile* profile, 138 void ShowWebsiteSettings(Profile* profile,
139 content::WebContents* web_contents, 139 content::WebContents* web_contents,
140 const GURL& url, 140 const GURL& url,
141 const content::SSLStatus& ssl) override; 141 const content::SSLStatus& ssl) override;
142 void ShowAppMenu() override; 142 void ShowAppMenu() override;
143 bool PreHandleKeyboardEvent(const content::NativeWebKeyboardEvent& event, 143 bool PreHandleKeyboardEvent(const content::NativeWebKeyboardEvent& event,
144 bool* is_keyboard_shortcut) override; 144 bool* is_keyboard_shortcut) override;
145 void HandleKeyboardEvent( 145 void HandleKeyboardEvent(
146 const content::NativeWebKeyboardEvent& event) override; 146 const content::NativeWebKeyboardEvent& event) override;
147 void Cut() override; 147 void CutCopyPaste(int command_id) override;
148 void Copy() override;
149 void Paste() override;
150 WindowOpenDisposition GetDispositionForPopupBounds( 148 WindowOpenDisposition GetDispositionForPopupBounds(
151 const gfx::Rect& bounds) override; 149 const gfx::Rect& bounds) override;
152 FindBar* CreateFindBar() override; 150 FindBar* CreateFindBar() override;
153 web_modal::WebContentsModalDialogHost* GetWebContentsModalDialogHost() 151 web_modal::WebContentsModalDialogHost* GetWebContentsModalDialogHost()
154 override; 152 override;
155 void ShowAvatarBubbleFromAvatarButton( 153 void ShowAvatarBubbleFromAvatarButton(
156 AvatarBubbleMode mode, 154 AvatarBubbleMode mode,
157 const signin::ManageAccountsParams& manage_accounts_params) override; 155 const signin::ManageAccountsParams& manage_accounts_params) override;
158 int GetRenderViewHeightInsetWithDetachedBookmarkBar() override; 156 int GetRenderViewHeightInsetWithDetachedBookmarkBar() override;
159 void ExecuteExtensionCommand(const extensions::Extension* extension, 157 void ExecuteExtensionCommand(const extensions::Extension* extension,
(...skipping 27 matching lines...) Expand all
187 NSWindow* window() const; // Accessor for the (current) |NSWindow|. 185 NSWindow* window() const; // Accessor for the (current) |NSWindow|.
188 186
189 Browser* browser_; // weak, owned by controller 187 Browser* browser_; // weak, owned by controller
190 BrowserWindowController* controller_; // weak, owns us 188 BrowserWindowController* controller_; // weak, owns us
191 base::scoped_nsobject<NSString> pending_window_title_; 189 base::scoped_nsobject<NSString> pending_window_title_;
192 ui::WindowShowState initial_show_state_; 190 ui::WindowShowState initial_show_state_;
193 NSInteger attention_request_id_; // identifier from requestUserAttention 191 NSInteger attention_request_id_; // identifier from requestUserAttention
194 }; 192 };
195 193
196 #endif // CHROME_BROWSER_UI_COCOA_BROWSER_WINDOW_COCOA_H_ 194 #endif // CHROME_BROWSER_UI_COCOA_BROWSER_WINDOW_COCOA_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/browser_window.h ('k') | chrome/browser/ui/cocoa/browser_window_cocoa.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698