Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1091683002: Docs: Update quota mgmt API docs to use methods that don't throw console warnings. (Closed)

Created:
5 years, 8 months ago by paulirish
Modified:
5 years, 8 months ago
Reviewers:
mkearney1
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Docs: Update quota mgmt API docs to use methods that don't throw console warnings. BUG= Committed: https://crrev.com/e059652f467fe22e87a1566acb1da91a7c134d23 Cr-Commit-Position: refs/heads/master@{#325364}

Patch Set 1 #

Total comments: 1

Patch Set 2 : addressing nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -24 lines) Patch
M chrome/common/extensions/docs/templates/articles/offline_storage.html View 1 4 chunks +22 lines, -24 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
paulirish
5 years, 8 months ago (2015-04-16 00:19:19 UTC) #2
mkearney1
lgtm with tiny nit (that might even be OK) https://codereview.chromium.org/1091683002/diff/1/chrome/common/extensions/docs/templates/articles/offline_storage.html File chrome/common/extensions/docs/templates/articles/offline_storage.html (right): https://codereview.chromium.org/1091683002/diff/1/chrome/common/extensions/docs/templates/articles/offline_storage.html#newcode187 chrome/common/extensions/docs/templates/articles/offline_storage.html:187: ...
5 years, 8 months ago (2015-04-16 00:25:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1091683002/20001
5 years, 8 months ago (2015-04-16 00:36:52 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-16 01:00:08 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/e059652f467fe22e87a1566acb1da91a7c134d23 Cr-Commit-Position: refs/heads/master@{#325364}
5 years, 8 months ago (2015-04-16 01:01:02 UTC) #8
paulirish
5 years, 8 months ago (2015-04-16 14:49:17 UTC) #9
Message was sent while issue was closed. 
This will be live at
https://developer.chrome.com/apps/offline_storage#managing_quota when ever it
goes up. Sometime soon…

Powered by Google App Engine
This is Rietveld 408576698