Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issue 10916355: Use PBuffer to make TextureImageTransportSurface current. (Closed)

Created:
8 years, 3 months ago by no sievers
Modified:
8 years, 3 months ago
Reviewers:
piman
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium
Visibility:
Public.

Description

Use offscreen surface to make TextureImageTransportSurface current. This is a first step to eliminate dependencies on the parent context. Instead of using the UI context's surface handle, use a 1x1 offscreen surface to make the renderer's compositor context current. (The actual rendering goes to FBOs.) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157415

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -5 lines) Patch
M content/common/gpu/texture_image_transport_surface.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M content/common/gpu/texture_image_transport_surface.cc View 1 5 chunks +14 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
no sievers
Ok, let's see what I can break. Would something like this work with AURA? https://codereview.chromium.org/10916355/diff/1/content/common/gpu/texture_image_transport_surface.cc ...
8 years, 3 months ago (2012-09-18 00:17:01 UTC) #1
piman
https://codereview.chromium.org/10916355/diff/1/content/common/gpu/texture_image_transport_surface.cc File content/common/gpu/texture_image_transport_surface.cc (right): https://codereview.chromium.org/10916355/diff/1/content/common/gpu/texture_image_transport_surface.cc#newcode92 content/common/gpu/texture_image_transport_surface.cc:92: surface_ = new gfx::PbufferGLSurfaceEGL(false, gfx::Size(1, 1)); This'll break because ...
8 years, 3 months ago (2012-09-18 00:19:41 UTC) #2
no sievers
https://codereview.chromium.org/10916355/diff/1/content/common/gpu/texture_image_transport_surface.cc File content/common/gpu/texture_image_transport_surface.cc (right): https://codereview.chromium.org/10916355/diff/1/content/common/gpu/texture_image_transport_surface.cc#newcode92 content/common/gpu/texture_image_transport_surface.cc:92: surface_ = new gfx::PbufferGLSurfaceEGL(false, gfx::Size(1, 1)); On 2012/09/18 00:19:42, ...
8 years, 3 months ago (2012-09-18 00:41:27 UTC) #3
piman
lgtm
8 years, 3 months ago (2012-09-18 00:42:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sievers@chromium.org/10916355/5001
8 years, 3 months ago (2012-09-18 18:08:30 UTC) #5
commit-bot: I haz the power
8 years, 3 months ago (2012-09-18 20:57:10 UTC) #6
Change committed as 157415

Powered by Google App Engine
This is Rietveld 408576698