Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 10916331: Revert 156348 (caused http://crbug.com/149828) (Closed)

Created:
8 years, 3 months ago by Nico
Modified:
8 years, 3 months ago
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, nkostylev+watch_chromium.org, Aaron Boodman, darin-cc_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Revert 156348 (caused http://crbug.com/149828) - Change getDevices to use a DeviceCallback. This modifies the getDevices method of the bluetooth Extensions API to accept a DeviceCallback, which will be called for every matching device. This will allow more thorough, long-running searches (involving SDP queries) to be performed without slowing down access to matching devices that can be returned quickly. TEST=api test updated BUG=134545 Review URL: https://chromiumcodereview.appspot.com/10915148 TBR=bryeung@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=157030

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -288 lines) Patch
M chrome/browser/chromeos/bluetooth/bluetooth_device.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/bluetooth/test/mock_bluetooth_device.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/extensions/bluetooth_event_router.h View 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/extensions/bluetooth_event_router.cc View 3 chunks +14 lines, -16 lines 0 comments Download
M chrome/browser/extensions/api/bluetooth/bluetooth_api.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/bluetooth/bluetooth_api.cc View 4 chunks +11 lines, -18 lines 0 comments Download
M chrome/browser/extensions/api/bluetooth/bluetooth_apitest_chromeos.cc View 4 chunks +80 lines, -78 lines 0 comments Download
M chrome/browser/extensions/event_names.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/event_names.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/experimental_bluetooth.idl View 2 chunks +5 lines, -13 lines 0 comments Download
M chrome/renderer/resources/extensions/experimental.bluetooth_custom_bindings.js View 4 chunks +9 lines, -49 lines 0 comments Download
D chrome/test/data/extensions/api_test/bluetooth/test_getdevices.html View 1 chunk +0 lines, -6 lines 0 comments Download
D chrome/test/data/extensions/api_test/bluetooth/test_getdevices.js View 1 chunk +0 lines, -55 lines 0 comments Download
D chrome/test/data/extensions/api_test/bluetooth/test_getdevices_concurrently.html View 1 chunk +0 lines, -6 lines 0 comments Download
D chrome/test/data/extensions/api_test/bluetooth/test_getdevices_concurrently.js View 1 chunk +0 lines, -31 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nico
8 years, 3 months ago (2012-09-16 00:35:08 UTC) #1
not at google - send to devlin
The breakage is more likely caused by 157025, more specifically, - 157025 causes functions not ...
8 years, 3 months ago (2012-09-16 01:21:16 UTC) #2
not at google - send to devlin
P.S. I reverted 157025.
8 years, 3 months ago (2012-09-16 01:21:33 UTC) #3
Nico
Thanks! Can you revert this revert then? (I'm not at a computer atm and won't ...
8 years, 3 months ago (2012-09-16 01:36:01 UTC) #4
Nico
8 years, 3 months ago (2012-09-16 12:24:10 UTC) #5
byreung: kalman reverted the revert in r157036 (thanks!)

On Sat, Sep 15, 2012 at 6:35 PM, Nico Weber <thakis@chromium.org> wrote:
> Thanks! Can you revert this revert then? (I'm not at a computer atm and
> won't be for a few hours)
>
> On Sep 16, 2012 10:21 AM, <kalman@chromium.org> wrote:
>>
>> P.S. I reverted 157025.
>>
>> https://codereview.chromium.org/10916331/

Powered by Google App Engine
This is Rietveld 408576698