Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 10916330: Convert dartdoc to use Args package (Closed)

Created:
8 years, 3 months ago by butlermatt
Modified:
8 years, 3 months ago
CC:
reviews_dartlang.org, ahe
Visibility:
Public.

Description

Convert dartdoc to use Args package See http://dartbug.com/3384 commited here: https://codereview.chromium.org/10951024/ BUG=

Patch Set 1 #

Total comments: 2

Patch Set 2 : Include reference to find-as-you-type in help for static file generation. #

Patch Set 3 : Add missing invocation display. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -124 lines) Patch
M pkg/dartdoc/bin/dartdoc.dart View 1 2 2 chunks +130 lines, -124 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
butlermatt
Per your comments and bug, converted to use Args package
8 years, 3 months ago (2012-09-15 20:39:30 UTC) #1
ahe
On 2012/09/15 20:39:30, butlermatt wrote: > Per your comments and bug, converted to use Args ...
8 years, 3 months ago (2012-09-17 08:31:53 UTC) #2
ahe
8 years, 3 months ago (2012-09-17 08:32:15 UTC) #3
Johnni Winther
lgtm https://codereview.chromium.org/10916330/diff/1/pkg/dartdoc/bin/dartdoc.dart File pkg/dartdoc/bin/dartdoc.dart (right): https://codereview.chromium.org/10916330/diff/1/pkg/dartdoc/bin/dartdoc.dart#newcode49 pkg/dartdoc/bin/dartdoc.dart:49: 'highlighting code.', 'find-as-you-type' is also dynamically created.
8 years, 3 months ago (2012-09-17 09:29:00 UTC) #4
Johnni Winther
On 2012/09/17 09:29:00, Johnni Winther wrote: > lgtm > > https://codereview.chromium.org/10916330/diff/1/pkg/dartdoc/bin/dartdoc.dart > File pkg/dartdoc/bin/dartdoc.dart (right): ...
8 years, 3 months ago (2012-09-17 09:43:10 UTC) #5
butlermatt
Added reference to find-as-you-type search box in help for static file generation mode. https://chromiumcodereview.appspot.com/10916330/diff/1/pkg/dartdoc/bin/dartdoc.dart File ...
8 years, 3 months ago (2012-09-17 12:13:42 UTC) #6
butlermatt
One small additional patch to include a missing command invocation in help.
8 years, 3 months ago (2012-09-17 17:00:35 UTC) #7
Bob Nystrom
LGTM! Peter, I generally think mixing options and non-option args is asking for trouble given ...
8 years, 3 months ago (2012-09-17 22:57:13 UTC) #8
butlermatt
8 years, 3 months ago (2012-09-18 18:23:35 UTC) #9
On 2012/09/17 09:43:10, Johnni Winther wrote:
> On 2012/09/17 09:29:00, Johnni Winther wrote:
> > lgtm
> > 
> > https://codereview.chromium.org/10916330/diff/1/pkg/dartdoc/bin/dartdoc.dart
> > File pkg/dartdoc/bin/dartdoc.dart (right):
> > 
> >
>
https://codereview.chromium.org/10916330/diff/1/pkg/dartdoc/bin/dartdoc.dart#...
> > pkg/dartdoc/bin/dartdoc.dart:49: 'highlighting code.',
> > 'find-as-you-type' is also dynamically created.
> 
> Once you've updated the CL cf. the comment, I'll commit it for you.

If it looks good to you now, can you commit this for me?
Thanks,
Matt

Powered by Google App Engine
This is Rietveld 408576698