Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 10916309: [Android] Remove the dependency on TabContents. (Closed)

Created:
8 years, 3 months ago by mnaganov (inactive)
Modified:
8 years, 3 months ago
Reviewers:
joth, Avi (use Gerrit), android-webview-reviews
CC:
chromium-reviews, Avi (use Gerrit)
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

[Android] Remove the dependency on TabContents. So far, all Aw tests that we have don't change their state after removing this dependency. We will need things like AutoFillManager, FaviconTabHelper, PasswordManager and SSLHelper, but it looks like it will be better to componentize them in the first place. R=joth@chromium.org,android-webview-reviews@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=157328

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove friend decl from TabContents #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -17 lines) Patch
M android_webview/lib/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
M android_webview/lib/aw_browser_dependency_factory_impl.cc View 3 chunks +7 lines, -9 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents.h View 1 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
mnaganov (inactive)
8 years, 3 months ago (2012-09-14 02:16:29 UTC) #1
joth
lgtm
8 years, 3 months ago (2012-09-14 20:31:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mnaganov@chromium.org/10916309/1
8 years, 3 months ago (2012-09-14 20:31:06 UTC) #3
Avi (use Gerrit)
http://codereview.chromium.org/10916309/diff/1/android_webview/lib/aw_browser_dependency_factory_impl.cc File android_webview/lib/aw_browser_dependency_factory_impl.cc (left): http://codereview.chromium.org/10916309/diff/1/android_webview/lib/aw_browser_dependency_factory_impl.cc#oldcode104 android_webview/lib/aw_browser_dependency_factory_impl.cc:104: TabContents::Factory::CreateTabContents(contents)); Thank you. Please remove the friend declaration from ...
8 years, 3 months ago (2012-09-14 20:36:00 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build. Your ...
8 years, 3 months ago (2012-09-14 22:48:57 UTC) #5
Avi (use Gerrit)
8 years, 3 months ago (2012-09-15 00:43:06 UTC) #6
LGTM!

Powered by Google App Engine
This is Rietveld 408576698