Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 10916301: drive: Stop exposing operation_registry() from DriveServiceInterface (Closed)

Created:
8 years, 3 months ago by hashimoto
Modified:
8 years, 3 months ago
Reviewers:
achuithb, satorux1, kinaba
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, nkostylev+watch_chromium.org, derat+watch_chromium.org, achuith+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

drive: Stop exposing operation_registry() from DriveServiceInterface Remove DriveServiceInterface::operation_registry() Add the following methods to DriveServiceInterface: CancelForFilePath(), GetProgressStatusList() Add the following methods to DriveServiceObserver and wire these events: OnProgressUpdate(), OnAuthenticationFailed() Move the following types out from OperationRegistry: OperationType, OperationTransferState, OperationProgressUpdate, OperationProgressUpdateList Move the following functions out from OperationRegistry: OperationTypeToString(), OperationTransferStateToString() BUG=147358 TEST=git try -b linux_chromeos Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156830 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=157316

Patch Set 1 #

Patch Set 2 : Reduce a few lines #

Patch Set 3 : rebase #

Patch Set 4 : Fix broken RemoteFileSystemExtensionApiTest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+246 lines, -201 lines) Patch
M chrome/browser/chromeos/extensions/external_filesystem_apitest.cc View 1 2 3 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_browser_event_router.h View 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_browser_event_router.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_browser_private_api.cc View 1 2 5 chunks +3 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager_util.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager_util.cc View 1 2 5 chunks +5 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/gdata/drive_api_service.h View 1 2 4 chunks +11 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/gdata/drive_api_service.cc View 1 2 6 chunks +31 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/gdata/drive_protocol_handler.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/gdata/drive_service_interface.h View 1 2 2 chunks +14 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_contacts_service.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/gdata/gdata_wapi_service.h View 1 2 3 chunks +11 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_wapi_service.cc View 1 2 6 chunks +31 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/gdata/mock_drive_service.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/gdata/mock_drive_service.cc View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/system/ash_system_tray_delegate.cc View 1 2 11 chunks +14 lines, -25 lines 0 comments Download
M chrome/browser/google_apis/gdata_operations.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/google_apis/gdata_operations_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/google_apis/operation_registry.h View 6 chunks +60 lines, -56 lines 0 comments Download
M chrome/browser/google_apis/operation_registry.cc View 11 chunks +16 lines, -19 lines 0 comments Download
M chrome/browser/google_apis/operation_registry_unittest.cc View 1 8 chunks +16 lines, -18 lines 0 comments Download
M chrome/browser/google_apis/operations_base.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/google_apis/operations_base.cc View 6 chunks +8 lines, -9 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/drive_internals_ui.cc View 1 2 2 chunks +5 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
hashimoto
Low priority clean up patch. Please review when you have time.
8 years, 3 months ago (2012-09-13 22:47:21 UTC) #1
satorux1
LGTM. This is a nice cleanup. I suspect you are procrastinating from something.
8 years, 3 months ago (2012-09-13 23:29:34 UTC) #2
hashimoto
On 2012/09/13 23:29:34, satorux1 wrote: > LGTM. This is a nice cleanup. > > I ...
8 years, 3 months ago (2012-09-13 23:41:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/10916301/2002
8 years, 3 months ago (2012-09-14 00:11:30 UTC) #4
commit-bot: I haz the power
Retried try job too often for step(s) unit_tests, sync_unit_tests
8 years, 3 months ago (2012-09-14 03:17:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/10916301/2002
8 years, 3 months ago (2012-09-14 03:58:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/10916301/2002
8 years, 3 months ago (2012-09-14 17:44:39 UTC) #7
commit-bot: I haz the power
Change committed as 156830
8 years, 3 months ago (2012-09-14 17:47:42 UTC) #8
hashimoto
Trying to reland this, RemoteFileSystemExtensionApiTest is fixed. kinaba, Could you review the test fix?
8 years, 3 months ago (2012-09-18 04:23:47 UTC) #9
kinaba
lgtm
8 years, 3 months ago (2012-09-18 04:32:13 UTC) #10
satorux1
8 years, 3 months ago (2012-09-18 13:23:49 UTC) #11
I'm very worried if this patch landed before the branch cut or not. If it didn't
land before the branch cut, we should revert this. As mentioned elsewhere, after
the branch cut, Drive code will enter the "no refactoring" period.

Powered by Google App Engine
This is Rietveld 408576698