Issue 10916283: mac: use png otr icon asset instead of pdf

Issue 10916283: mac: use png otr icon asset instead of pdf (Closed)

Created:
8 years, 3 months ago by Nico

Modified:
8 years, 3 months ago

Reviewers:
Robert Sesek

CC:
chromium-reviews, oshima+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

mac: use png otr icon asset instead of pdf BUG=111101 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=156727

Patch Set 1 #

Total comments: 2

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -4 lines)			Patch
M	chrome/app/theme/theme_resources.grd	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/browser/avatar_button_controller.mm	View	1 chunk	+3 lines, -2 lines	2 comments	Download
M	chrome/chrome_dll.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Nico

The otr_icon.png asset is partially transparent and look wrong. Landing this will wait until I ...

8 years, 3 months ago (2012-09-13 08:14:22 UTC) #1

Robert Sesek

LGTM https://codereview.chromium.org/10916283/diff/1/chrome/browser/ui/cocoa/browser/avatar_button_controller.mm File chrome/browser/ui/cocoa/browser/avatar_button_controller.mm (right): https://codereview.chromium.org/10916283/diff/1/chrome/browser/ui/cocoa/browser/avatar_button_controller.mm#newcode138 chrome/browser/ui/cocoa/browser/avatar_button_controller.mm:138: [self setImage:[self compositeImageWithShadow:otrIcon]]; Use .ToNSImage(). The operator is ...

8 years, 3 months ago (2012-09-13 13:17:55 UTC) #3

Nico

On 2012/09/13 08:14:22, Nico wrote: > The otr_icon.png asset is partially transparent and look wrong. ...

8 years, 3 months ago (2012-09-14 02:06:17 UTC) #4

Nico

8 years, 3 months ago (2012-09-14 02:08:39 UTC) #5

https://codereview.chromium.org/10916283/diff/1/chrome/browser/ui/cocoa/brows...
File chrome/browser/ui/cocoa/browser/avatar_button_controller.mm (right):

https://codereview.chromium.org/10916283/diff/1/chrome/browser/ui/cocoa/brows...
chrome/browser/ui/cocoa/browser/avatar_button_controller.mm:138: [self
setImage:[self compositeImageWithShadow:otrIcon]];
On 2012/09/13 13:17:55, rsesek wrote:
> Use .ToNSImage(). The operator is deprecated.

Done.

Expand Messages | Collapse Messages