Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 10916253: Support custom cursors for windowless plugins on Windows Aura. (Closed)

Created:
8 years, 3 months ago by jam
Modified:
8 years, 3 months ago
Reviewers:
tony, ananta
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Support custom cursors for windowless plugins on Windows Aura. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=156347

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -49 lines) Patch
M webkit/glue/webcursor.h View 3 chunks +13 lines, -8 lines 0 comments Download
M webkit/glue/webcursor.cc View 1 4 chunks +47 lines, -2 lines 2 comments Download
M webkit/glue/webcursor_win.cc View 2 chunks +0 lines, -36 lines 0 comments Download
M webkit/plugins/npapi/webplugin_delegate_impl_win.cc View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jam
8 years, 3 months ago (2012-09-12 01:05:24 UTC) #1
jam
actually, please hold off on reviewing this until I can verify this. I think there ...
8 years, 3 months ago (2012-09-12 01:13:47 UTC) #2
jam
ok I've tested with a bunch of flash sites that have cursors, and have made ...
8 years, 3 months ago (2012-09-12 06:08:21 UTC) #3
jam
+tony for the webkit/glue changes
8 years, 3 months ago (2012-09-12 18:29:50 UTC) #4
ananta
lgtm
8 years, 3 months ago (2012-09-12 18:32:18 UTC) #5
tony
LGTM https://codereview.chromium.org/10916253/diff/6002/webkit/glue/webcursor.cc File webkit/glue/webcursor.cc (right): https://codereview.chromium.org/10916253/diff/6002/webkit/glue/webcursor.cc#newcode177 webkit/glue/webcursor.cc:177: for (int i = 0; i < arraysize(kStandardCursors); ...
8 years, 3 months ago (2012-09-12 18:58:09 UTC) #6
jam
8 years, 3 months ago (2012-09-12 19:40:10 UTC) #7
https://codereview.chromium.org/10916253/diff/6002/webkit/glue/webcursor.cc
File webkit/glue/webcursor.cc (right):

https://codereview.chromium.org/10916253/diff/6002/webkit/glue/webcursor.cc#n...
webkit/glue/webcursor.cc:177: for (int i = 0; i < arraysize(kStandardCursors);
i++) {
On 2012/09/12 18:58:09, tony wrote:
> Nit: ++i

Done.

Powered by Google App Engine
This is Rietveld 408576698