Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Unified Diff: pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart

Issue 1091613003: Revert "dart2js: add compiler builtins to the core-runtime." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart
diff --git a/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart b/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart
index 2e07d9b2d01d4a63097bcca113abc01b5ba6f549..31fdea5e63f962ac523e5f3d3a2469f4df1e7352 100644
--- a/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart
+++ b/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart
@@ -269,39 +269,6 @@ class OldEmitter implements Emitter {
return globalPropertyAccess(element);
}
- @override
- jsAst.Template templateForBuiltin(JsBuiltin builtin) {
- switch (builtin) {
- case JsBuiltin.dartObjectConstructor:
- return jsAst.js.expressionTemplateYielding(
- typeAccess(compiler.objectClass));
-
- case JsBuiltin.isFunctionType:
- return backend.rti.representationGenerator.templateForIsFunctionType;
-
- case JsBuiltin.isFunctionTypeLiteral:
- String functionClassName =
- backend.namer.runtimeTypeName(compiler.functionClass);
- return jsAst.js.expressionTemplateFor(
- '#.$typeNameProperty === "$functionClassName"');
-
- case JsBuiltin.typeName:
- return jsAst.js.expressionTemplateFor("#.$typeNameProperty");
-
- case JsBuiltin.rawRuntimeType:
- return jsAst.js.expressionTemplateFor("#.constructor");
-
- case JsBuiltin.createFunctionType:
- return backend.rti.representationGenerator
- .templateForCreateFunctionType;
-
- default:
- compiler.internalError(NO_LOCATION_SPANNABLE,
- "Unhandled Builtin: $builtin");
- return null;
- }
- }
-
List<jsAst.Statement> buildTrivialNsmHandlers(){
return nsmEmitter.buildTrivialNsmHandlers();
}
@@ -1048,7 +1015,7 @@ class OldEmitter implements Emitter {
cspPrecompiledFunctionFor(outputUnit).add(js.statement(r'''
{
- #constructorName.#typeNameProperty = #constructorNameString;
+ #constructorName.builtin$cls = #constructorNameString;
if (!"name" in #constructorName)
#constructorName.name = #constructorNameString;
$desc = $collectedClasses.#constructorName[1];
@@ -1059,7 +1026,6 @@ class OldEmitter implements Emitter {
}
}''',
{"constructorName": constructorName,
- "typeNameProperty": typeNameProperty,
"constructorNameString": js.string(constructorName),
"hasIsolateSupport": hasIsolateSupport,
"fieldNamesArray": fieldNamesArray}));

Powered by Google App Engine
This is Rietveld 408576698