Revert "dart2js: add compiler builtins to the core-runtime."

pkg/compiler/lib/src/ssa/builder.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of ssa;
 
 class SsaFunctionCompiler implements FunctionCompiler {
   SsaCodeGeneratorTask generator;
   SsaBuilderTask builder;
   SsaOptimizerTask optimizer;
@@ skipping 3755 matching lines @@
       compiler.reportError(
           node, MessageKind.GENERIC,
           {'text': 'Error: Expected one argument to JS_GET_NAME.'});
       return;
     case 1:
       argument = arguments[0];
       break;
     default:
       for (int i = 1; i < arguments.length; i++) {
         compiler.reportError(
-           arguments[i], MessageKind.GENERIC,
+            arguments[i], MessageKind.GENERIC,
             {'text': 'Error: Extra argument to JS_GET_NAME.'});
       }
       return;
     }
     Element element = elements[argument];
     if (element == null ||
         element is! FieldElement ||
         element.enclosingClass != backend.jsGetNameEnum) {
       compiler.reportError(
           argument, MessageKind.GENERIC,
           {'text': 'Error: Expected a JsGetName enum value.'});
     }
     EnumClassElement enumClass = element.enclosingClass;
     int index = enumClass.enumValues.indexOf(element);
     stack.add(
         addConstantString(
             backend.namer.getNameForJsGetName(
                 argument, JsGetName.values[index])));
   }
 
-  void handleForeignJsBuiltin(ast.Send node) {
-    List<ast.Node> arguments = node.arguments.toList();
-    ast.Node argument;
-    if (arguments.length < 2) {
-      compiler.reportError(
-          node, MessageKind.GENERIC,
-          {'text': 'Error: Expected at least two arguments to JS_BUILTIN.'});
-    }
-
-    Element builtinElement = elements[arguments[1]];
-    if (builtinElement == null ||
-        (builtinElement is! FieldElement) ||
-        builtinElement.enclosingClass != backend.jsBuiltinEnum) {
-      compiler.reportError(
-          argument, MessageKind.GENERIC,
-          {'text': 'Error: Expected a JsBuiltin enum value.'});
-    }
-    EnumClassElement enumClass = builtinElement.enclosingClass;
-    int index = enumClass.enumValues.indexOf(builtinElement);
-
-    js.Template template =
-        backend.emitter.builtinTemplateFor(JsBuiltin.values[index]);
-
-    List<HInstruction> compiledArguments = <HInstruction>[];
-    for (int i = 2; i < arguments.length; i++) {
-      visit(arguments[i]);
-      compiledArguments.add(pop());
-    }
-
-    native.NativeBehavior nativeBehavior =
-        compiler.enqueuer.resolution.nativeEnqueuer.getNativeBehaviorOf(node);
-
-    TypeMask ssaType =
-        TypeMaskFactory.fromNativeBehavior(nativeBehavior, compiler);
-
-    push(new HForeignCode(template,
-                          ssaType,
-                          compiledArguments,
-                          nativeBehavior: nativeBehavior));
-  }
-
   void handleForeignJsEmbeddedGlobal(ast.Send node) {
     List<ast.Node> arguments = node.arguments.toList();
     ast.Node globalNameNode;
     switch (arguments.length) {
     case 0:
     case 1:
       compiler.reportError(
           node, MessageKind.GENERIC,
           {'text': 'Error: Expected two arguments to JS_EMBEDDED_GLOBAL.'});
       return;
     case 2:
       // The type has been extracted earlier. We are only interested in the
       // name in this function.
       globalNameNode = arguments[1];
       break;
     default:
       for (int i = 2; i < arguments.length; i++) {
         compiler.reportError(
             arguments[i], MessageKind.GENERIC,
             {'text': 'Error: Extra argument to JS_EMBEDDED_GLOBAL.'});
       }
       return;
     }
-    visit(globalNameNode);
+    visit(arguments[1]);
     HInstruction globalNameHNode = pop();
     if (!globalNameHNode.isConstantString()) {
       compiler.reportError(
           arguments[1], MessageKind.GENERIC,
           {'text': 'Error: Expected String as second argument '
                    'to JS_EMBEDDED_GLOBAL.'});
       return;
     }
     HConstant hConstant = globalNameHNode;
     StringConstantValue constant = hConstant.constant;
@@ skipping 103 matching lines @@
     SideEffects sideEffects = new SideEffects.empty();
     sideEffects.setAllSideEffects();
     push(new HForeignCode(
         js.js.parseForeignJS("$isolateName = #"),
         backend.dynamicType,
         <HInstruction>[pop()],
         nativeBehavior: native.NativeBehavior.PURE,
         effects: sideEffects));
   }
 
+  void handleForeignDartObjectJsConstructorFunction(ast.Send node) {
+    if (!node.arguments.isEmpty) {
+      compiler.internalError(node.argumentsNode, 'Too many arguments.');
+    }
+    push(new HForeignCode(
+        js.js.expressionTemplateYielding(
+            backend.emitter.typeAccess(compiler.objectClass)),
+        backend.dynamicType,
+        <HInstruction>[]));
+  }
+
   void handleForeignJsCurrentIsolate(ast.Send node) {
     if (!node.arguments.isEmpty) {
       compiler.internalError(node.argumentsNode, 'Too many arguments.');
     }
     push(new HForeignCode(js.js.parseForeignJS(backend.namer.currentIsolate),
                           backend.dynamicType,
                           <HInstruction>[]));
   }
 
   visitForeignSend(ast.Send node) {
@@ skipping 15 matching lines @@
       // TODO(floitsch): this should be a JS_NAME.
       stack.add(addConstantString(backend.namer.operatorIsPrefix));
     } else if (name == 'JS_OBJECT_CLASS_NAME') {
       // TODO(floitsch): this should be a JS_NAME.
       String name = backend.namer.runtimeTypeName(compiler.objectClass);
       stack.add(addConstantString(name));
     } else if (name == 'JS_NULL_CLASS_NAME') {
       // TODO(floitsch): this should be a JS_NAME.
       String name = backend.namer.runtimeTypeName(compiler.nullClass);
       stack.add(addConstantString(name));
+    } else if (name == 'JS_FUNCTION_CLASS_NAME') {
+      // TODO(floitsch): this should be a JS_NAME.
+      String name = backend.namer.runtimeTypeName(compiler.functionClass);
+      stack.add(addConstantString(name));
     } else if (name == 'JS_OPERATOR_AS_PREFIX') {
       // TODO(floitsch): this should be a JS_NAME.
       stack.add(addConstantString(backend.namer.operatorAsPrefix));
     } else if (name == 'JS_SIGNATURE_NAME') {
       // TODO(floitsch): this should be a JS_NAME.
       stack.add(addConstantString(backend.namer.operatorSignature));
     } else if (name == 'JS_TYPEDEF_TAG') {
       // TODO(floitsch): this should be a JS_NAME.
       stack.add(addConstantString(backend.namer.typedefTag));
+    } else if (name == 'JS_FUNCTION_TYPE_TAG') {
+      // TODO(floitsch): this should be a JS_NAME.
+      stack.add(addConstantString(backend.namer.functionTypeTag));
     } else if (name == 'JS_FUNCTION_TYPE_VOID_RETURN_TAG') {
       // TODO(floitsch): this should be a JS_NAME.
       stack.add(addConstantString(backend.namer.functionTypeVoidReturnTag));
     } else if (name == 'JS_FUNCTION_TYPE_RETURN_TYPE_TAG') {
       // TODO(floitsch): this should be a JS_NAME.
       stack.add(addConstantString(backend.namer.functionTypeReturnTypeTag));
     } else if (name ==
                'JS_FUNCTION_TYPE_REQUIRED_PARAMETERS_TAG') {
       // TODO(floitsch): this should be a JS_NAME.
       stack.add(addConstantString(
           backend.namer.functionTypeRequiredParametersTag));
     } else if (name ==
                'JS_FUNCTION_TYPE_OPTIONAL_PARAMETERS_TAG') {
       // TODO(floitsch): this should be a JS_NAME.
       stack.add(addConstantString(
           backend.namer.functionTypeOptionalParametersTag));
     } else if (name ==
                'JS_FUNCTION_TYPE_NAMED_PARAMETERS_TAG') {
       // TODO(floitsch): this should be a JS_NAME.
       stack.add(addConstantString(
           backend.namer.functionTypeNamedParametersTag));
+    } else if (name == 'JS_DART_OBJECT_CONSTRUCTOR') {
+      handleForeignDartObjectJsConstructorFunction(node);
     } else if (name == 'JS_IS_INDEXABLE_FIELD_NAME') {
       // TODO(floitsch): this should be a JS_NAME.
       Element element = backend.findHelper('JavaScriptIndexingBehavior');
       stack.add(addConstantString(backend.namer.operatorIs(element)));
     } else if (name == 'JS_CURRENT_ISOLATE') {
       handleForeignJsCurrentIsolate(node);
     } else if (name == 'JS_GET_NAME') {
       handleForeignJsGetName(node);
     } else if (name == 'JS_EMBEDDED_GLOBAL') {
       handleForeignJsEmbeddedGlobal(node);
-    } else if (name == 'JS_BUILTIN') {
-      handleForeignJsBuiltin(node);
     } else if (name == 'JS_GET_FLAG') {
       handleForeingJsGetFlag(node);
     } else if (name == 'JS_EFFECT') {
       stack.add(graph.addConstantNull(compiler));
     } else if (name == 'JS_INTERCEPTOR_CONSTANT') {
       handleJsInterceptorConstant(node);
     } else if (name == 'JS_STRING_CONCAT') {
       handleJsStringConcat(node);
     } else {
       throw "Unknown foreign: ${selector}";
@@ skipping 2954 matching lines @@
     if (unaliased is TypedefType) throw 'unable to unalias $type';
     unaliased.accept(this, builder);
   }
 
   void visitDynamicType(DynamicType type, SsaBuilder builder) {
     JavaScriptBackend backend = builder.compiler.backend;
     ClassElement cls = backend.findHelper('DynamicRuntimeType');
     builder.push(new HDynamicType(type, new TypeMask.exact(cls, classWorld)));
   }
 }