Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Issue 1091613002: Update README per recommendations from Seth: (Closed)

Created:
5 years, 8 months ago by eseidel
Modified:
5 years, 8 months ago
Reviewers:
sethladd, Hixie
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : Updated per revieww #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M sky/sdk/README.md View 1 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (1 generated)
eseidel
5 years, 8 months ago (2015-04-15 18:34:21 UTC) #1
eseidel
5 years, 8 months ago (2015-04-15 18:34:39 UTC) #3
Hixie
https://codereview.chromium.org/1091613002/diff/1/sky/sdk/README.md File sky/sdk/README.md (right): https://codereview.chromium.org/1091613002/diff/1/sky/sdk/README.md#newcode35 sky/sdk/README.md:35: Node build() => new Text('Hello, world!'); The reason not ...
5 years, 8 months ago (2015-04-15 19:10:31 UTC) #4
sethladd
https://codereview.chromium.org/1091613002/diff/1/sky/sdk/README.md File sky/sdk/README.md (right): https://codereview.chromium.org/1091613002/diff/1/sky/sdk/README.md#newcode35 sky/sdk/README.md:35: Node build() => new Text('Hello, world!'); Totally fair. https://codereview.chromium.org/1091613002/diff/1/sky/sdk/README.md#newcode65 ...
5 years, 8 months ago (2015-04-15 19:20:19 UTC) #5
eseidel
So my understanding is that part #1 was done for copy/pasta support. And Part #2 ...
5 years, 8 months ago (2015-04-15 19:33:45 UTC) #6
sethladd
Ignore #1 suggestion. +1 for removing void as a return type annotation, and keeping async ...
5 years, 8 months ago (2015-04-15 19:35:18 UTC) #7
eseidel
Ian tells me removing void would be the same as: Future<dynamic> main() async { Will ...
5 years, 8 months ago (2015-04-15 19:36:47 UTC) #8
sethladd
You can use Future or Future<dynamic>. IMO, since nothing listens to what main() returns (generally ...
5 years, 8 months ago (2015-04-15 19:46:52 UTC) #9
eseidel
ptal
5 years, 8 months ago (2015-04-15 19:51:23 UTC) #10
sethladd
lgtm thanks!
5 years, 8 months ago (2015-04-15 19:57:11 UTC) #11
eseidel
5 years, 8 months ago (2015-04-15 20:26:58 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
4a66a47cd460f6521e306fbd1ae513e67a931eee (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698