net/base/multi_threaded_cert_verifier.cc - Issue 10916094: Move the NSS functions out of CertDatabase into a new NSSCertDatabase class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/multi_threaded_cert_verifier.cc

Issue 10916094: Move the NSS functions out of CertDatabase into a new NSSCertDatabase class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed comments Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/base/multi_threaded_cert_verifier.cc

diff --git a/net/base/multi_threaded_cert_verifier.cc b/net/base/multi_threaded_cert_verifier.cc

index b2c3a0a434cfdc5a66fc946ece208ee05518c3b6..577c4551d2a1cba67430b860a2748f24723b7b6b 100644

--- a/net/base/multi_threaded_cert_verifier.cc

+++ b/net/base/multi_threaded_cert_verifier.cc

@@ -382,13 +382,15 @@ MultiThreadedCertVerifier::MultiThreadedCertVerifier()

cache_hits_(0),

inflight_joins_(0),

verify_proc_(CertVerifyProc::CreateDefault()) {

- CertDatabase::AddObserver(this);

+ CertDatabase cert_db;

+ cert_db.AddObserver(this);

}

MultiThreadedCertVerifier::~MultiThreadedCertVerifier() {

STLDeleteValues(&inflight_);

- CertDatabase::RemoveObserver(this);

+ CertDatabase cert_db;

+ cert_db.RemoveObserver(this);

}

int MultiThreadedCertVerifier::Verify(X509Certificate* cert,

« net/base/cert_database.cc ('K') | « net/base/cert_database_win.cc ('k') | net/base/nss_cert_database.h » ('j') | net/base/nss_cert_database.h » ('J')