Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: chrome/browser/chromeos/cros/onc_network_parser.cc

Issue 10916094: Move the NSS functions out of CertDatabase into a new NSSCertDatabase class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comments Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/cros/onc_network_parser.cc
diff --git a/chrome/browser/chromeos/cros/onc_network_parser.cc b/chrome/browser/chromeos/cros/onc_network_parser.cc
index 8814d0cb3d1dddf57500882a572486c78d74a33e..e8986516c744e3ba7a6030428d4e822d21d4c684 100644
--- a/chrome/browser/chromeos/cros/onc_network_parser.cc
+++ b/chrome/browser/chromeos/cros/onc_network_parser.cc
@@ -28,9 +28,9 @@
#include "crypto/scoped_nss_types.h"
#include "crypto/symmetric_key.h"
#include "grit/generated_resources.h"
-#include "net/base/cert_database.h"
#include "net/base/crypto_module.h"
#include "net/base/net_errors.h"
+#include "net/base/nss_cert_database.h"
#include "net/base/pem_tokenizer.h"
#include "net/base/x509_certificate.h"
#include "net/proxy/proxy_bypass_rules.h"
@@ -525,7 +525,7 @@ scoped_refptr<net::X509Certificate> OncNetworkParser::ParseCertificate(
if (!certificate->GetBoolean("Remove", &remove))
remove = false;
- net::CertDatabase cert_database;
+ net::NSSCertDatabase cert_database;
if (remove) {
if (!DeleteCertAndKeyByNickname(guid)) {
parse_error_ = l10n_util::GetStringUTF8(
@@ -822,7 +822,7 @@ OncNetworkParser::ParseServerOrCaCertificate(
const std::string& cert_type,
const std::string& guid,
base::DictionaryValue* certificate) {
- net::CertDatabase cert_database;
+ net::NSSCertDatabase cert_database;
bool web_trust = false;
base::ListValue* trust_list = NULL;
if (certificate->GetList("Trust", &trust_list)) {
@@ -951,11 +951,11 @@ OncNetworkParser::ParseServerOrCaCertificate(
net::CertificateList cert_list;
cert_list.push_back(x509_cert);
- net::CertDatabase::ImportCertFailureList failures;
+ net::NSSCertDatabase::ImportCertFailureList failures;
bool success = false;
- net::CertDatabase::TrustBits trust = web_trust ?
- net::CertDatabase::TRUSTED_SSL :
- net::CertDatabase::TRUST_DEFAULT;
+ net::NSSCertDatabase::TrustBits trust = web_trust ?
+ net::NSSCertDatabase::TRUSTED_SSL :
+ net::NSSCertDatabase::TRUST_DEFAULT;
if (cert_type == "Server") {
success = cert_database.ImportServerCert(cert_list, trust, &failures);
} else { // Authority cert
@@ -987,7 +987,7 @@ scoped_refptr<net::X509Certificate> OncNetworkParser::ParseClientCertificate(
int cert_index,
const std::string& guid,
base::DictionaryValue* certificate) {
- net::CertDatabase cert_database;
+ net::NSSCertDatabase cert_database;
std::string pkcs12_data;
if (!certificate->GetString("PKCS12", &pkcs12_data) ||
pkcs12_data.empty()) {
@@ -1072,7 +1072,7 @@ ClientCertType OncNetworkParser::ParseClientCertType(
void OncNetworkParser::ListCertsWithNickname(const std::string& label,
net::CertificateList* result) {
net::CertificateList all_certs;
- net::CertDatabase cert_db;
+ net::NSSCertDatabase cert_db;
cert_db.ListCerts(&all_certs);
result->clear();
for (net::CertificateList::iterator iter = all_certs.begin();
@@ -1111,7 +1111,7 @@ void OncNetworkParser::ListCertsWithNickname(const std::string& label,
bool OncNetworkParser::DeleteCertAndKeyByNickname(const std::string& label) {
net::CertificateList cert_list;
ListCertsWithNickname(label, &cert_list);
- net::CertDatabase cert_db;
+ net::NSSCertDatabase cert_db;
bool result = true;
for (net::CertificateList::iterator iter = cert_list.begin();
iter != cert_list.end(); ++iter) {

Powered by Google App Engine
This is Rietveld 408576698