Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5724)

Unified Diff: chrome/common/chrome_switches.cc

Issue 10916016: Switch the TCP reads on Windows to use non-blocking/non-async I/O. (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/chrome_switches.cc
===================================================================
--- chrome/common/chrome_switches.cc (revision 163292)
+++ chrome/common/chrome_switches.cc (working copy)
@@ -1540,6 +1540,12 @@
// Windows 8 and higher. Used when relaunching metro Chrome.
const char kForceDesktop[] = "force-desktop";
+// Allows for disabling the overlapped I/O for TCP reads.
+// Possible values are "on" or "off".
+// The default is "on" which matches the existing behavior.
rvargas (doing something else) 2012/10/23 00:19:40 I'm a little confused by this. The "normal" patter
pmeenan 2012/10/23 14:29:54 The command line can force the trial on or off (fo
rvargas (doing something else) 2012/10/24 18:48:09 Thanks for the explanation... I figured it was for
+// "off" switches to use non-blocking reads and WSAEventSelect.
+const char kOverlappedRead[] = "overlapped-reads";
+
// Relaunches metro Chrome on Windows 8 and higher using a given shortcut.
const char kRelaunchShortcut[] = "relaunch-shortcut";

Powered by Google App Engine
This is Rietveld 408576698