Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1091563002: PPC: Use Cells to check prototype chain validity (disabled by default). (Closed)

Created:
5 years, 8 months ago by MTBrandyberry
Modified:
5 years, 8 months ago
Reviewers:
michael_dawson, dstence
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Use Cells to check prototype chain validity (disabled by default). Port 0179ec57975c5063bbecd98e11cdda77ddad8996 Original commit message: The cells are stored on prototypes (in their map's PrototypeInfo). When a prototype object changes its map, then both its own validity cell and those of all "downstream" prototypes are invalidated; handlers for a given receiver embed the currently valid cell for that receiver's prototype during their compilation and check it on execution. R=michael_dawson@ca.ibm.com, dstence@us.ibm.com BUG= Committed: https://crrev.com/0dc5fd7080daee1925aed292108ce8ecc8e464c2 Cr-Commit-Position: refs/heads/master@{#27849}

Patch Set 1 #

Patch Set 2 : Fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -16 lines) Patch
M src/ic/ppc/handler-compiler-ppc.cc View 1 5 chunks +54 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
MTBrandyberry
Fix PPC build break.
5 years, 8 months ago (2015-04-15 14:10:41 UTC) #1
michael_dawson
On 2015/04/15 14:10:41, mtbrandyberry wrote: > Fix PPC build break. lgtm.
5 years, 8 months ago (2015-04-15 14:13:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1091563002/20001
5 years, 8 months ago (2015-04-15 14:16:16 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-15 14:40:03 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 14:40:10 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0dc5fd7080daee1925aed292108ce8ecc8e464c2
Cr-Commit-Position: refs/heads/master@{#27849}

Powered by Google App Engine
This is Rietveld 408576698