Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: src/objects-inl.h

Issue 1091553002: Re-enable an UNREACHABLE in JSObject::GetHeaderSize() (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: proper patch Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects-inl.h
diff --git a/src/objects-inl.h b/src/objects-inl.h
index e5e8235c292a15049f7afffd4ca0d0b9b9eb85fb..be0cb47dbce51875a548461b250242216a6dd2ed 100644
--- a/src/objects-inl.h
+++ b/src/objects-inl.h
@@ -1979,9 +1979,7 @@ int JSObject::GetHeaderSize() {
case JS_MESSAGE_OBJECT_TYPE:
return JSMessageObject::kSize;
default:
- // TODO(jkummerow): Re-enable this. Blink currently hits this
- // from its CustomElementConstructorBuilder.
- // UNREACHABLE();
+ UNREACHABLE();
return 0;
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698