[remoting_unittests] Moving the variable used to mock VideoFrameCapturer::size_most_recent() to the…

[remoting_unittests] Moving the variable used to mock VideoFrameCapturer::size_most_recent() to the test class scope so it is availabe in TearDown() while running the outstanding tasks.

This CL also:
- removes the corresponding memcheck supression;
- DCHECKs that the host has been properly deleted by ChromotingHostTest.* tests before reaching TearDown(). This should help to avoid memory leaks similar to ones that were fixed by r156494.

BUG=148828, 148883
TEST=remoting_unittests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=156619

[alexeypa (please no reviews), 2012-09-13 16:31:52]

PTAL.

[simonmorris, 2012-09-13 16:51:40]

http://codereview.chromium.org/10915264/diff/1/remoting/host/chromoting_host_...
File remoting/host/chromoting_host_unittest.cc (right):

http://codereview.chromium.org/10915264/diff/1/remoting/host/chromoting_host_...
remoting/host/chromoting_host_unittest.cc:220: message_loop_.Run();
I'm not convinced the benefits of this exceed the costs.

It's surprising to have the main loop, where (for almost all tests) all the work
is actually done, occur in a method called TearDown.

And it makes Reconnect() harder to understand. "Why is there a
message_loop.Run() after the first SimulateClientConnection(), but not the
second? Oh, I see: the other message_loop.Run() is in a method where I don't
expect it, 300 lines anyway."

[alexeypa (please no reviews), 2012-09-13 18:06:16]

PTAL.

http://codereview.chromium.org/10915264/diff/1/remoting/host/chromoting_host_...
File remoting/host/chromoting_host_unittest.cc (right):

http://codereview.chromium.org/10915264/diff/1/remoting/host/chromoting_host_...
remoting/host/chromoting_host_unittest.cc:220: message_loop_.Run();
On 2012/09/13 16:51:40, simonmorris wrote:
> I'm not convinced the benefits of this exceed the costs.
> 
> It's surprising to have the main loop, where (for almost all tests) all the
work
> is actually done, occur in a method called TearDown.
> 
> And it makes Reconnect() harder to understand. "Why is there a
> message_loop.Run() after the first SimulateClientConnection(), but not the
> second? Oh, I see: the other message_loop.Run() is in a method where I don't
> expect it, 300 lines anyway."

Done.

[simonmorris, 2012-09-13 18:10:32]

lgtm