Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Unified Diff: content/renderer/webplugin_delegate_proxy.cc

Issue 10915065: Add PlatformPictureSkia and RecordingPlatformDeviceSkia. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add IsPlatformPaintSupported(), update comment in WebPluginDelegateProxy::Paint and require direct … Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/webplugin_delegate_proxy.cc
diff --git a/content/renderer/webplugin_delegate_proxy.cc b/content/renderer/webplugin_delegate_proxy.cc
index 7793797a134256bcbb72dc050bb52eb39c530df2..93161b1a2f6e7710d74764507129bfbc58a6ae70 100644
--- a/content/renderer/webplugin_delegate_proxy.cc
+++ b/content/renderer/webplugin_delegate_proxy.cc
@@ -757,12 +757,9 @@ void WebPluginDelegateProxy::Paint(WebKit::WebCanvas* canvas,
return;
// We're using the native OS APIs from here on out.
- if (!skia::SupportsPlatformPaint(canvas)) {
- // TODO(alokp): Implement this path.
- // This block will only get hit with --enable-accelerated-drawing flag.
- // With accelerated canvas, we do not have a bitmap that can be provided
- // to the plugin for compositing. We may have to implement a solution
- // described in crbug.com/12586.
+ if (!skia::IsPlatformPaintSupported(canvas)) {
+ // This block will only get hit when we do not have a bitmap that can be
+ // provided to the plugin for compositing.
DLOG(WARNING) << "Could not paint plugin";
return;
}

Powered by Google App Engine
This is Rietveld 408576698