Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Issue 1091463002: Remove -Wa,--noexecstack flag on Android. (Closed)

Created:
5 years, 8 months ago by pcc1
Modified:
5 years, 8 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove -Wa,--noexecstack flag on Android. This flag causes unused argument errors when using LTO (or Clang's integrated assembler), and is not needed to disable executable stacks, as we are already passing -Wl,-z,noexecstack at link time, which is how executable stacks are already getting disabled on other platforms. BUG=407544 R=thakis@chromium.org TEST=Built libchromeshell.so with default GYP_DEFINES with and without this change, verified that binaries are equivalent Committed: https://crrev.com/8c865340749de6de14d68b64d69af6942e445f69 Cr-Commit-Position: refs/heads/master@{#325375}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M build/common.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (1 generated)
pcc1
5 years, 8 months ago (2015-04-15 05:13:29 UTC) #1
Nico
Does assembler output always go through the linker? Or is there a way to effectively ...
5 years, 8 months ago (2015-04-15 16:40:47 UTC) #2
pcc1
On 2015/04/15 16:40:47, Nico wrote: > Does assembler output always go through the linker? I ...
5 years, 8 months ago (2015-04-16 00:46:59 UTC) #3
Nico
lgtm
5 years, 8 months ago (2015-04-16 00:54:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1091463002/1
5 years, 8 months ago (2015-04-16 00:55:24 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-16 02:08:28 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 02:09:34 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8c865340749de6de14d68b64d69af6942e445f69
Cr-Commit-Position: refs/heads/master@{#325375}

Powered by Google App Engine
This is Rietveld 408576698