Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 10914317: Fix casting error for receiver of interceptors. (Closed)

Created:
8 years, 3 months ago by Michael Starzinger
Modified:
8 years, 3 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Fix casting error for receiver of interceptors. This fixes a casting error that occured when the receiver of a missed or uninitialized CallIC is a Smi and there is an interceptor installed on the prototype chain. R=yangguo@chromium.org BUG=chromium:149912 TEST=cctest/test-api/Regress149912 Committed: https://code.google.com/p/v8/source/detail?r=12531

Patch Set 1 #

Patch Set 2 : Moar consistency. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -11 lines) Patch
M src/objects.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M src/objects.cc View 1 4 chunks +6 lines, -8 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Michael Starzinger
8 years, 3 months ago (2012-09-17 14:21:17 UTC) #1
Yang
8 years, 3 months ago (2012-09-17 14:27:32 UTC) #2
On 2012/09/17 14:21:17, Michael Starzinger wrote:

LGTM.

Powered by Google App Engine
This is Rietveld 408576698