Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(798)

Unified Diff: chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc

Issue 109143005: Files.app: Fix a call of the default task picker. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix C++ side bug. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/file_manager/foreground/js/file_manager.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc
diff --git a/chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc b/chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc
index fa4573077533334e181a5089ab5ee919691517d8..b0244ef87237f0a272ce171727a3780910167794 100644
--- a/chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc
+++ b/chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc
@@ -47,9 +47,11 @@ std::set<std::string> GetUniqueMimeTypes(
const std::vector<std::string>& mime_type_list) {
std::set<std::string> mime_types;
for (size_t i = 0; i < mime_type_list.size(); ++i) {
- std::string mime_type;
- // We'll skip empty MIME types.
- if (!mime_type.empty())
+ const std::string mime_type = mime_type_list[i];
+ // We'll skip empty MIME types and existing MIME types.
+ if (!mime_type.empty() ||
+ std::find(mime_types.begin(), mime_types.end(), mime_type) ==
yoshiki 2013/12/10 07:00:29 We don't need to check duplication explicitly sinc
hirono 2013/12/10 10:05:33 Oops, I missed it. Thanks!
+ mime_types.end())
mime_types.insert(mime_type);
}
return mime_types;
« no previous file with comments | « no previous file | chrome/browser/resources/file_manager/foreground/js/file_manager.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698