Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 109143005: Files.app: Fix a call of the default task picker. (Closed)

Created:
7 years ago by hirono
Modified:
7 years ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, arv+watch_chromium.org, kinaba
Visibility:
Public.

Description

Files.app: Fix a call of the default task picker. Previouslly Files.app cannot oepn the default task picker. This is caused by replacing urls with entries of FileSelection. This CL fixes the call of the default task picker by using entries. BUG=326913 TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240601

Patch Set 1 #

Patch Set 2 : Fix C++ side bug. #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : addressed a comment #

Patch Set 5 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc View 1 2 4 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/file_manager/foreground/js/file_manager.js View 1 2 3 4 3 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
hirono
PTAL the CL? Thanks!
7 years ago (2013-12-09 07:53:55 UTC) #1
yoshiki
https://codereview.chromium.org/109143005/diff/20001/chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc File chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc (right): https://codereview.chromium.org/109143005/diff/20001/chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc#newcode53 chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc:53: std::find(mime_types.begin(), mime_types.end(), mime_type) == We don't need to check ...
7 years ago (2013-12-10 07:00:29 UTC) #2
hirono
https://codereview.chromium.org/109143005/diff/20001/chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc File chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc (right): https://codereview.chromium.org/109143005/diff/20001/chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc#newcode53 chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc:53: std::find(mime_types.begin(), mime_types.end(), mime_type) == On 2013/12/10 07:00:29, yoshiki wrote: ...
7 years ago (2013-12-10 10:05:33 UTC) #3
hirono
On 2013/12/10 10:05:33, hirono wrote: > https://codereview.chromium.org/109143005/diff/20001/chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc > File chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc > (right): > > https://codereview.chromium.org/109143005/diff/20001/chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc#newcode53 ...
7 years ago (2013-12-12 02:52:17 UTC) #4
yoshiki
lgtm
7 years ago (2013-12-12 13:15:15 UTC) #5
hirono
On 2013/12/12 13:15:15, yoshiki wrote: > lgtm Thanks!
7 years ago (2013-12-12 15:28:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/109143005/140001
7 years ago (2013-12-12 15:28:34 UTC) #7
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=40968
7 years ago (2013-12-12 15:45:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/109143005/140001
7 years ago (2013-12-12 18:23:39 UTC) #9
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=41011
7 years ago (2013-12-12 18:49:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/109143005/160001
7 years ago (2013-12-13 02:10:41 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/109143005/160001
7 years ago (2013-12-13 06:42:53 UTC) #12
commit-bot: I haz the power
7 years ago (2013-12-13 12:01:12 UTC) #13
Message was sent while issue was closed. 
Change committed as 240601

Powered by Google App Engine
This is Rietveld 408576698