Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3)

Issue 10914295: Fix for msvs output on non-windows. (Closed)

Created:
5 years, 2 months ago by Sam Clegg
Modified:
5 years, 2 months ago
Reviewers:
bradnelson, Nico, bradn, scottmg
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Fix for msvs output on non-windows. Its a useful feature of gyp that one can generate msvs project on a non-windows machine. This change fixes the output of .vcproj files on non-windows. $ ./gyp --toplevel-dir=test/hello --format=msvs test/hello/hello.gyp This would previously generate a file called: "test\\hello\\hello.vcproj" Tested that the generated vcproj files for chromium are unaffected. BUG= Committed: https://code.google.com/p/gyp/source/detail?r=1500

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pylib/gyp/generator/msvs.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Sam Clegg
5 years, 2 months ago (2012-09-14 19:01:13 UTC) #1
bradn
lgtm
5 years, 2 months ago (2012-09-14 20:14:03 UTC) #2
scottmg
On 2012/09/14 19:01:13, Sam Clegg wrote: Does it make the sln prompt for saving where ...
5 years, 2 months ago (2012-09-14 20:17:02 UTC) #3
Sam Clegg
5 years, 2 months ago (2012-09-18 19:28:41 UTC) #4
On 2012/09/14 20:17:02, scottmg wrote:
> On 2012/09/14 19:01:13, Sam Clegg wrote:
> 
> Does it make the sln prompt for saving where it didn't before? (I don't much
> care since I don't use VS any more, but it might be a bit annoying for people
> who do)

Contents of sln and vcxproj files are not effected by this change,
modulo this issue which I am preparing a separate fix for:

http://code.google.com/p/gyp/issues/detail?id=296&thanks=296&ts=1347996407

Powered by Google App Engine
This is Rietveld efc10ee0f