Chromium Code Reviews
Help | Chromium Project | Sign in
(83)

Issue 10914295: Fix for msvs output on non-windows. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 7 months ago by Sam Clegg
Modified:
1 year, 7 months ago
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Fix for msvs output on non-windows.

Its a useful feature of gyp that one can generate
msvs project on a non-windows machine. This change
fixes the output of .vcproj files on non-windows.

$ ./gyp --toplevel-dir=test/hello --format=msvs test/hello/hello.gyp

This would previously generate a file called:

"test\\hello\\hello.vcproj"

Tested that the generated vcproj files for chromium
are unaffected.

BUG=

Committed: https://code.google.com/p/gyp/source/detail?r=1500

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Lint Patch
M pylib/gyp/generator/msvs.py View 1 chunk +1 line, -1 line 0 comments ? errors Download
Commit:

Messages

Total messages: 4
Sam Clegg
1 year, 7 months ago #1
bradn
lgtm
1 year, 7 months ago #2
scottmg
On 2012/09/14 19:01:13, Sam Clegg wrote: Does it make the sln prompt for saving where ...
1 year, 7 months ago #3
Sam Clegg
1 year, 7 months ago #4
On 2012/09/14 20:17:02, scottmg wrote:
> On 2012/09/14 19:01:13, Sam Clegg wrote:
> 
> Does it make the sln prompt for saving where it didn't before? (I don't much
> care since I don't use VS any more, but it might be a bit annoying for people
> who do)

Contents of sln and vcxproj files are not effected by this change,
modulo this issue which I am preparing a separate fix for:

http://code.google.com/p/gyp/issues/detail?id=296&thanks=296&ts=1347996407
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6