Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10914287: Speech JavaScript API: make available in about:flags (Closed)

Created:
8 years, 3 months ago by hans
Modified:
8 years, 3 months ago
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Speech JavaScript API: make available in about:flags Add an about:flags flag to make it easier for early adopters to try out the API. BUG=116954 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156845

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update flag description #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/tools/chromeactions.txt View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
hans
8 years, 3 months ago (2012-09-14 09:21:04 UTC) #1
Satish
lgtm https://codereview.chromium.org/10914287/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/10914287/diff/1/chrome/app/generated_resources.grd#newcode5619 chrome/app/generated_resources.grd:5619: + Speech JavaScript API. should this be Speech ...
8 years, 3 months ago (2012-09-14 09:37:58 UTC) #2
hans
https://codereview.chromium.org/10914287/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/10914287/diff/1/chrome/app/generated_resources.grd#newcode5619 chrome/app/generated_resources.grd:5619: + Speech JavaScript API. On 2012/09/14 09:37:58, Satish wrote: ...
8 years, 3 months ago (2012-09-14 09:41:49 UTC) #3
hans
ben: can you do OWNERS review for chrome/ ?
8 years, 3 months ago (2012-09-14 09:43:09 UTC) #4
Ben Goodger (Google)
lgtm On Fri, Sep 14, 2012 at 2:43 AM, <hans@chromium.org> wrote: > ben: can you ...
8 years, 3 months ago (2012-09-14 15:58:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/10914287/4001
8 years, 3 months ago (2012-09-14 16:22:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/10914287/4001
8 years, 3 months ago (2012-09-14 17:43:26 UTC) #7
commit-bot: I haz the power
8 years, 3 months ago (2012-09-14 18:31:40 UTC) #8 
Change committed as 156845

Powered by Google App Engine
This is Rietveld 408576698