Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6054)

Unified Diff: chrome/browser/webdata/web_intents_table_unittest.cc

Issue 10914278: Fix for non-sticky defaults bug. Added a bunch of tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix up comments. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/webdata/web_intents_table_unittest.cc
diff --git a/chrome/browser/webdata/web_intents_table_unittest.cc b/chrome/browser/webdata/web_intents_table_unittest.cc
index 64ff906f7f3180c184125c466f2060f019201dad..77888ec13ff11c05fab9eaed6a2b84f738c55114 100644
--- a/chrome/browser/webdata/web_intents_table_unittest.cc
+++ b/chrome/browser/webdata/web_intents_table_unittest.cc
@@ -332,7 +332,7 @@ TEST_F(WebIntentsTableTest, RemoveDefaultServicesForServiceURL) {
std::vector<DefaultWebIntentService> defaults;
ASSERT_TRUE(IntentsTable()->GetAllDefaultServices(&defaults));
- ASSERT_EQ(3U, defaults.size());
+ ASSERT_EQ(2U, defaults.size());
ASSERT_TRUE(IntentsTable()->RemoveServiceDefaults(test_service_url));
@@ -342,4 +342,27 @@ TEST_F(WebIntentsTableTest, RemoveDefaultServicesForServiceURL) {
EXPECT_EQ(test_service_url_2.spec(), defaults[0].service_url);
}
+TEST_F(WebIntentsTableTest, OverwriteDefaults) {
+ DefaultWebIntentService default_service;
+ default_service.action = test_action;
+ default_service.type = mime_image;
+ default_service.user_date = 1;
+ default_service.suppression = 4;
+ default_service.service_url = "service_url";
+ ASSERT_TRUE(IntentsTable()->SetDefaultService(default_service));
+
+ default_service.user_date = 2;
+ default_service.service_url = "service_url2";
+ ASSERT_TRUE(IntentsTable()->SetDefaultService(default_service));
+
+ default_service.user_date = 3;
+ default_service.service_url = "service_url3";
+ ASSERT_TRUE(IntentsTable()->SetDefaultService(default_service));
+
+ std::vector<DefaultWebIntentService> defaults;
+ ASSERT_TRUE(IntentsTable()->GetAllDefaultServices(&defaults));
+ ASSERT_EQ(1U, defaults.size());
+ EXPECT_EQ("service_url3", defaults[0].service_url);
+}
+
} // namespace

Powered by Google App Engine
This is Rietveld 408576698