Issue 10914266: Made clang use the gold linker for Android

Issue 10914266: Made clang use the gold linker for Android (Closed)

Created:
8 years, 3 months ago by michaelbai

Modified:
8 years, 3 months ago

Reviewers:
hans, bulach, eugenis, digit1

CC:
chromium-reviews, peter+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Made clang use the gold linker for Android Created 2 symbolic link to the gold linker in third_party/android_tools/ndk, and put them before the NDK's default linker in PATH environment variable, so clang could use the gold linker. BUG=143931 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=157132

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed comment and sync #

Patch Set 3 : Sync again #

Patch Set 4 : #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
A	build/android/arm-linux-androideabi-gold/arm-linux-androideabi-ld	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	build/android/arm-linux-androideabi-gold/ld	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	build/android/envsetup_functions.sh	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

eugenis

lgtm https://chromiumcodereview.appspot.com/10914266/diff/1/build/android/envsetup_functions.sh File build/android/envsetup_functions.sh (right): https://chromiumcodereview.appspot.com/10914266/diff/1/build/android/envsetup_functions.sh#newcode52 build/android/envsetup_functions.sh:52: # This must be set before ANDROID_TOOLCHAIN, so ...

8 years, 3 months ago (2012-09-14 08:50:34 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaelbai@chromium.org/10914266/1

8 years, 3 months ago (2012-09-14 17:23:33 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaelbai@chromium.org/10914266/1

8 years, 3 months ago (2012-09-14 17:42:58 UTC) #7

michaelbai

https://chromiumcodereview.appspot.com/10914266/diff/1/build/android/envsetup_functions.sh File build/android/envsetup_functions.sh (right): https://chromiumcodereview.appspot.com/10914266/diff/1/build/android/envsetup_functions.sh#newcode52 build/android/envsetup_functions.sh:52: # This must be set before ANDROID_TOOLCHAIN, so the ...

8 years, 3 months ago (2012-09-14 18:59:09 UTC) #8

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaelbai@chromium.org/10914266/1007

8 years, 3 months ago (2012-09-14 21:03:36 UTC) #9

commit-bot: I haz the power

8 years, 3 months ago (2012-09-14 23:48:05 UTC) #10

Retried try job too often for step(s) interactive_ui_tests, jingle_unittests,
gpu_unittests, base_unittests, sync_integration_tests, sql_unittests,
chrome_frame_unittests, content_unittests, safe_browsing_tests, ipc_tests,
mini_installer_test, cacheinvalidation_unittests, remoting_unittests,
browser_tests, net_unittests, installer_util_unittests, chrome_frame_net_tests,
check_deps, crypto_unittests, unit_tests, nacl_integration, media_unittests,
content_browsertests, printing_unittests, sync_unit_tests

Expand Messages | Collapse Messages