Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(743)

Unified Diff: chrome/browser/chrome_gpu_util.cc

Issue 10914247: Enable by default threaded compositing on windows and FCM on mac (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: shorten field trial period Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_gpu_util.cc
diff --git a/chrome/browser/chrome_gpu_util.cc b/chrome/browser/chrome_gpu_util.cc
index 90efc1246768600b631690ea153dc4a5f08a06d2..ae5e7e397f6a781cef73f4b4f7f62398161952f3 100644
--- a/chrome/browser/chrome_gpu_util.cc
+++ b/chrome/browser/chrome_gpu_util.cc
@@ -71,42 +71,44 @@ void InitializeCompositingFieldTrial() {
}
const base::FieldTrial::Probability kDivisor = 3;
+ // Note: This field trial should be removed once we're comfortable with
+ // turning force compositing mode and threaded compositing on all relevant
+ // platforms (see crbug.com/149991).
scoped_refptr<base::FieldTrial> trial(
base::FieldTrialList::FactoryGetFieldTrial(
content::kGpuCompositingFieldTrialName, kDivisor,
- "disable", 2012, 12, 31, NULL));
+ "disable", 2013, 12, 31, NULL));
// Produce the same result on every run of this client.
trial->UseOneTimeRandomization();
+ // Note: The static field trial probabilities set here can be overwritten
+ // at runtime by Finch. Changing these static values won't have an effect
+ // if a Finch study is active.
base::FieldTrial::Probability force_compositing_mode_probability = 0;
base::FieldTrial::Probability threaded_compositing_probability = 0;
+ // Threaded compositing mode isn't feature complete on mac or linux yet:
+ // http://crbug.com/133602 for mac
+ // http://crbug.com/140866 for linux
+
+#if defined(OS_WIN)
+ // threaded-compositing turned on by default on Windows.
+ // (Windows XP is excluded explicitly in ShouldRunCompositingFieldTrial)
+ threaded_compositing_probability = 3;
+#elif defined(OS_MACOSX)
+ // force-compositing-mode turned on by default on mac.
+ force_compositing_mode_probability = 3;
+#elif defined(OS_LINUX)
chrome::VersionInfo::Channel channel = chrome::VersionInfo::GetChannel();
- if (channel == chrome::VersionInfo::CHANNEL_STABLE ||
- channel == chrome::VersionInfo::CHANNEL_BETA) {
- // Stable and Beta channels: Non-threaded force-compositing-mode on by
- // default (mac and windows only).
-#if defined(OS_WIN) || defined(OS_MACOSX)
- force_compositing_mode_probability = 3;
-#endif
- } else if (channel == chrome::VersionInfo::CHANNEL_DEV ||
- channel == chrome::VersionInfo::CHANNEL_CANARY) {
- // Dev and Canary channels: force-compositing-mode and
+ if (channel != chrome::VersionInfo::CHANNEL_STABLE &&
+ channel != chrome::VersionInfo::CHANNEL_BETA) {
+ // On channels < beta, force-compositing-mode and
// threaded-compositing on with 1/3 probability each.
force_compositing_mode_probability = 1;
-
-#if defined(OS_MACOSX) || defined(OS_LINUX)
- // Threaded compositing mode isn't feature complete on mac or linux yet:
- // http://crbug.com/133602 for mac
- // http://crbug.com/140866 for linux
- threaded_compositing_probability = 0;
-#else
- if (!CommandLine::ForCurrentProcess()->HasSwitch(
- switches::kDisableThreadedCompositing))
- threaded_compositing_probability = 1;
-#endif
+ threaded_compositing_probability = 1;
}
+#endif
int force_compositing_group = trial->AppendGroup(
content::kGpuCompositingFieldTrialForceCompositingEnabledName,
« no previous file with comments | « no previous file | chrome/browser/task_manager/task_manager_browsertest.cc » ('j') | chrome/test/gpu/gpu_feature_browsertest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698