Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Unified Diff: components/signin/core/browser/account_tracker_service.cc

Issue 1091363002: Change ProfileDownloader to use AccountTrackerService. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Clean up unit test. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/signin/core/browser/account_tracker_service.cc
diff --git a/components/signin/core/browser/account_tracker_service.cc b/components/signin/core/browser/account_tracker_service.cc
index 5f2c1eb60523d6fd5e345f9bc5441ab5e34a94c8..16e1445b797e31fdc5ab9b562f20a7a2d18ba8fa 100644
--- a/components/signin/core/browser/account_tracker_service.cc
+++ b/components/signin/core/browser/account_tracker_service.cc
@@ -31,6 +31,7 @@ const char kAccountHostedDomainPath[] = "hd";
const char kAccountFullNamePath[] = "full_name";
const char kAccountGivenNamePath[] = "given_name";
const char kAccountLocalePath[] = "locale";
+const char kAccountPictureURLPath[] = "picture_url";
#if !defined(OS_ANDROID) && !defined(OS_IOS)
// IsRefreshTokenDeviceIdExperimentEnabled is called from
@@ -46,6 +47,9 @@ bool IsRefreshTokenDeviceIdExperimentEnabled() {
// This must be a string which can never be a valid domain.
const char AccountTrackerService::kNoHostedDomainFound[] = "NO_HOSTED_DOMAIN";
+// This must be a string which can never be a valid picture URL.
+const char AccountTrackerService::kNoPictureURLFound[] = "NO_PICTURE_URL";
+
class AccountInfoFetcher : public OAuth2TokenService::Consumer,
public gaia::GaiaOAuthClient::Delegate {
public:
@@ -169,10 +173,10 @@ void AccountInfoFetcher::OnNetworkError(int response_code) {
AccountTrackerService::AccountInfo::AccountInfo() {}
AccountTrackerService::AccountInfo::~AccountInfo() {}
-bool AccountTrackerService::AccountInfo::IsValid() {
+bool AccountTrackerService::AccountInfo::IsValid() const {
return !account_id.empty() && !email.empty() && !gaia.empty() &&
!hosted_domain.empty() && !full_name.empty() && !given_name.empty() &&
- !locale.empty();
+ !locale.empty() && !picture_url.empty();
}
@@ -432,6 +436,13 @@ void AccountTrackerService::SetAccountStateFromUserInfo(
user_info->GetString("given_name", &state.info.given_name);
user_info->GetString("locale", &state.info.locale);
+ std::string picture_url;
+ if(user_info->GetString("picture", &picture_url)) {
+ state.info.picture_url = picture_url;
+ } else {
+ state.info.picture_url = kNoPictureURLFound;
+ }
+
NotifyAccountUpdated(state);
SaveToPrefs(state);
}
@@ -488,6 +499,8 @@ void AccountTrackerService::LoadFromPrefs() {
state.info.given_name = base::UTF16ToUTF8(value);
if (dict->GetString(kAccountLocalePath, &value))
state.info.locale = base::UTF16ToUTF8(value);
+ if (dict->GetString(kAccountPictureURLPath, &value))
+ state.info.picture_url = base::UTF16ToUTF8(value);
if (state.info.IsValid())
NotifyAccountUpdated(state);
}
@@ -522,6 +535,7 @@ void AccountTrackerService::SaveToPrefs(const AccountState& state) {
dict->SetString(kAccountFullNamePath, state.info.full_name);
dict->SetString(kAccountGivenNamePath, state.info.given_name);
dict->SetString(kAccountLocalePath, state.info.locale);
+ dict->SetString(kAccountPictureURLPath, state.info.picture_url);
}
void AccountTrackerService::RemoveFromPrefs(const AccountState& state) {

Powered by Google App Engine
This is Rietveld 408576698